[TASK] Remove dependency to FileStreamWrapper

We can use vfs stream directly nowadays. Resolves: #89798 Releases: master Change-Id: Ie41eccb21dff70c6587bfd1380488697c4f6aca3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62473 Tested-by: Benni Mack <benni@typo3.org> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Benni Mack <benni@typo3.org> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
TYPO3 · Nov 28, 2019 · 0914114 · 0914114
1 parent fcb2780
commit 0914114
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 22 deletions.
diff --git a/typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php b/typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php
@@ -28,7 +28,6 @@
 use TYPO3\CMS\Core\Tests\Unit\Resource\BaseTestCase;
 use TYPO3\CMS\Core\Tests\Unit\Resource\Driver\Fixtures\LocalDriverFilenameFilter;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\TestingFramework\Core\FileStreamWrapper;
 
 /**
  * Test case
@@ -384,24 +383,22 @@ public function getSpecificFileInformationDataProvider(): array
      */
     public function getSpecificFileInformationReturnsRequestedFileInformation($expectedValue, string $property): void
     {
-        $root = vfsStream::setup();
+        $root = vfsStream::setup('root');
+
         $subFolder = vfsStream::newDirectory('fileadmin');
         $root->addChild($subFolder);
+
         // Load fixture files and folders from disk
         $directory = vfsStream::copyFromFileSystem(__DIR__ . '/Fixtures/', $subFolder, 1024 * 1024);
         if (in_array($property, ['mtime', 'ctime', 'atime'])) {
             $expectedValue = $directory->getChild('Dummy.html')->filemtime();
         }
-        FileStreamWrapper::init(Environment::getPublicPath() . '/');
-        FileStreamWrapper::registerOverlayPath('fileadmin', 'vfs://root/fileadmin', false);
 
-        $subject = $this->createDriver(['basePath' => Environment::getPublicPath() . '/fileadmin']);
+        $subject = $this->createDriver(['basePath' => 'vfs://root/fileadmin']);
         self::assertSame(
             $expectedValue,
-            $subject->getSpecificFileInformation(Environment::getPublicPath() . '/fileadmin/Dummy.html', '/', $property)
+            $subject->getSpecificFileInformation('vfs://root/fileadmin/Dummy.html', '/', $property)
         );
-
-        FileStreamWrapper::destroy();
     }
 
     /**
@@ -676,22 +673,18 @@ public function createFileFixesPermissionsOnCreatedFile(): void
      */
     public function getFileReturnsCorrectIdentifier(): void
     {
-        $root = vfsStream::setup();
+        $root = vfsStream::setup('root');
         $subFolder = vfsStream::newDirectory('fileadmin');
         $root->addChild($subFolder);
         // Load fixture files and folders from disk
         vfsStream::copyFromFileSystem(__DIR__ . '/Fixtures/', $subFolder, 1024 * 1024);
-        FileStreamWrapper::init(Environment::getPublicPath() . '/');
-        FileStreamWrapper::registerOverlayPath('fileadmin/', 'vfs://root/fileadmin/', false);
 
-        $subject = $this->createDriver(['basePath' => Environment::getPublicPath() . '/fileadmin']);
+        $subject = $this->createDriver(['basePath' => 'vfs://root/fileadmin']);
 
         $subdirFileInfo = $subject->getFileInfoByIdentifier('Dummy.html');
         self::assertEquals('/Dummy.html', $subdirFileInfo['identifier']);
         $rootFileInfo = $subject->getFileInfoByIdentifier('LocalDriverFilenameFilter.php');
         self::assertEquals('/LocalDriverFilenameFilter.php', $rootFileInfo['identifier']);
-
-        FileStreamWrapper::destroy();
     }
 
     /**

diff --git a/typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php b/typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
@@ -37,7 +37,6 @@
 use TYPO3\CMS\Core\Tests\Unit\Utility\Fixtures\TwoParametersConstructorFixture;
 use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\TestingFramework\Core\FileStreamWrapper;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
 /**
@@ -2897,13 +2896,9 @@ public function mkdirDeepCreatesDirectoryWithAndWithoutDoubleSlashesDataProvider
      */
     public function mkdirDeepCreatesDirectoryWithDoubleSlashes($directoryToCreate)
     {
-        vfsStream::setup();
-        // Load fixture files and folders from disk
-        FileStreamWrapper::init(Environment::getPublicPath());
-        FileStreamWrapper::registerOverlayPath('fileadmin', 'vfs://root/fileadmin', true);
-        GeneralUtility::mkdir_deep(Environment::getPublicPath() . '/' . $directoryToCreate);
-        self::assertTrue(is_dir(Environment::getPublicPath() . '/' . $directoryToCreate));
-        FileStreamWrapper::destroy();
+        vfsStream::setup('root', null, ['public' => []]);
+        GeneralUtility::mkdir_deep('vfs://root/public/' . $directoryToCreate);
+        self::assertTrue(is_dir('vfs://root/public/' . $directoryToCreate));
     }
 
     /**