Skip to content

Commit

Permalink
[DOCS] Revise 12.4.x changelogs
Browse files Browse the repository at this point in the history
This patch streamlines some spellings, break long code lines,
so so they are visible without horizontal scrolling and adds
more context to the RTE configuration examples.

Resolves: #103677
Releases: main, 12.4
Change-Id: I2366888a29b90ee59d76f1b8f6876eb600b730d7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83930
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
  • Loading branch information
brotkrueml authored and lolli42 committed Apr 19, 2024
1 parent 54f5bdf commit 09cf9ee
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 17 deletions.
Expand Up @@ -10,7 +10,7 @@ See :issue:`100889`

.. important::
This change was introduced as part of the
`TYPO3 12.4.4 and 11.5.30 security releases <https://typo3.org/security/advisory/typo3-core-sa-2023-003>`__.
`TYPO3 v12.4.4 and v11.5.30 security releases <https://typo3.org/security/advisory/typo3-core-sa-2023-003>`__.

Description
===========
Expand Down
Expand Up @@ -11,7 +11,7 @@ See :issue:`100925`
Description
===========

To implement native json database field and TCA `type=json`
To implement native JSON database field and TCA `type=json`
support for TYPO3 v12 the need to cache the database schema
information raised due to performance reason.

Expand Down
Expand Up @@ -11,7 +11,7 @@ See :issue:`101567`
Description
===========

The symfony PHP attribute :php:`\Symfony\Component\Console\Attribute\AsCommand`
The Symfony PHP attribute :php:`\Symfony\Component\Console\Attribute\AsCommand`
is now accepted to register console commands.
This way CLI commands can be registered by setting the attribute on the command
class. Only the parameters `command`, `description`, `aliases` and `hidden` are
Expand Down Expand Up @@ -49,7 +49,11 @@ attribute is assigned to the command class instead:
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Attribute\AsCommand;
#[AsCommand(name: 'myprefix:dofoo', description: 'My description', aliases: ['myprefix:dofoo-alias'])]
#[AsCommand(
name: 'myprefix:dofoo',
description: 'My description',
aliases: ['myprefix:dofoo-alias']
)]
class MyCommand extends Command
{
}
Expand Down
Expand Up @@ -11,7 +11,7 @@ See :issue:`102314`
Description
===========

The `IconViewhelper` in EXT:core has been extended for a new argument `title`.
The `IconViewhelper` in EXT:core has been extended with a new argument `title`.
The new argument allows to set a corresponding title, which will be rendered
as `title` attribute in the icon HTML markup. The `title` attribute will only
be rendered, if explicitly passed. You can also pass an empty string.
Expand All @@ -33,9 +33,17 @@ This will be rendered as:

.. code-block:: html

<span title="Open actions menu" class="t3js-icon icon icon-size-small icon-state-default icon-actions-menu" data-identifier="actions-menu" aria-hidden="true">
<span
title="Open actions menu"
class="t3js-icon icon icon-size-small icon-state-default icon-actions-menu"
data-identifier="actions-menu" aria-hidden="true"
>
<span class="icon-markup">
<img src="/typo3/sysext/core/Resources/Public/Icons/T3Icons/actions/actions-menu.svg" width="16" height="16">
<img
src="/typo3/sysext/core/Resources/Public/Icons/T3Icons/actions/actions-menu.svg"
width="16"
height="16"
>
</span>
</span>

Expand Down
Expand Up @@ -18,9 +18,11 @@ from the default configuration:

.. code-block:: yaml
htmlSupport:
allow:
- { classes: true, attributes: { pattern: 'data-.+' } }
editor:
config:
htmlSupport:
allow:
- { classes: true, attributes: { pattern: 'data-.+' } }
The configuration matched to any HTML element available in the CKEditor5 General
HTML Support (GHS) schema definition.
Expand All @@ -29,22 +31,26 @@ classes when processing content that is pasted from Microsoft Office.

Installations that relied on the fact that v12.4.7 allowed all CSS classes in
CKEditor5 should encode the set of available style definitions via
`editor.config.style.definitions` which will make them accessible to editors
:yaml:`editor.config.style.definitions` which will make them accessible to editors
via the style dropdown toolbar element:

.. code-block:: yaml
style:
definitions:
- { name: "Descriptive Label", element: "p", classes: ['my-class'] }
editor:
config:
style:
definitions:
- { name: "Descriptive Label", element: "p", classes: ['my-class'] }
Custom data attributes can be allowed via General HTML Support:

.. code-block:: yaml
htmlSupport:
allow:
- { name: 'div', attributes: ['data-foobar'] }
editor:
config:
htmlSupport:
allow:
- { name: 'div', attributes: ['data-foobar'] }
.. index:: RTE, YAML, ext:rte_ckeditor

0 comments on commit 09cf9ee

Please sign in to comment.