[BUGFIX] Avoid updating element header in form editor inspector

When changing values in the form editor inspector, their header content is updated and overridden - as a result the corresponding type icon in the header suddenly disappears. Resolves: #97841 Releases: main, 11.5, 10.4 Change-Id: I18bbd668a16a5b350a14cfa565fb5b96ab205fe8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75012 Tested-by: waldhacker <hello@waldhacker.dev> Tested-by: core-ci <typo3@b13.com> Tested-by: Oliver Hader <oliver.hader@typo3.org> Reviewed-by: waldhacker <hello@waldhacker.dev> Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
TYPO3 · Jul 2, 2022 · 0b8932e · 0b8932e
1 parent 07447e0
commit 0b8932e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/InspectorComponent.js b/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/InspectorComponent.js
@@ -2574,6 +2574,7 @@ define(['jquery',
      *
      * @param string content
      * @return void
+     * @deprecated not used anymore, will be removed in TYPO3 v12.0
      */
     function setFormElementHeaderEditorContent(content) {
       if (getFormEditorApp().getUtility().isUndefinedOrNull(content)) {

diff --git a/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/Mediator.js b/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/Mediator.js
@@ -823,11 +823,9 @@ define(['jquery',
         if ('renderables' !== args[0]) {
           if (!getFormEditorApp().isRootFormElementSelected() && 'label' === args[0]) {
             getViewModel().getStructure().setTreeNodeTitle();
-            getViewModel().setInspectorFormElementHeaderEditorContent();
           } else if (!getFormEditorApp().getUtility().isUndefinedOrNull(args[3]) && getRootFormElement().get('__identifierPath') === args[3]) {
             getViewModel().setStructureRootElementTitle();
             getViewModel().setStageHeadline();
-            getViewModel().setInspectorFormElementHeaderEditorContent();
           }
 
           if (getViewModel().getPreviewMode()) {

diff --git a/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/ViewModel.js b/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/ViewModel.js
@@ -882,6 +882,7 @@ define(['jquery',
      *
      * @param string content
      * @return void
+     * @deprecated not used anymore, will be removed in TYPO3 v12.0
      */
     function setInspectorFormElementHeaderEditorContent(content) {
       getInspector().setFormElementHeaderEditorContent(content);