Skip to content

Commit

Permalink
[TASK] Update TypeScript and friends, September 2023
Browse files Browse the repository at this point in the history
This patch updates `typescript` to 5.2 and `@typescript-eslint` packages
to 6.6. Updating `@typescript-eslint` revealed a broken condition in
the `@typo3/backend/viewport/navigation-container` module that is now
removed.

Executed command:

    npm install --save-dev \
        @typescript-eslint/eslint-plugin@^6.6.0 \
        @typescript-eslint/parser@^6.6.0 \
        @typescript-eslint/typescript-estree@^6.6.0 \
        typescript@~5.2.2

Resolves: #101864
Releases: main, 12.4
Change-Id: I7fd1e5997b6b19124d8fcac8402db79d3fd05f6d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80890
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
  • Loading branch information
andreaskienast committed Sep 7, 2023
1 parent cd56e42 commit 0e05189
Show file tree
Hide file tree
Showing 6 changed files with 120 additions and 156 deletions.
Expand Up @@ -97,14 +97,12 @@ class NavigationContainer extends AbstractContainer {
const parent = this.parent;
const container = this.container;
container.querySelectorAll(ScaffoldIdentifierEnum.contentNavigationDataComponent).forEach((el: HTMLElement) => el.style.display = 'none');
if (typeof component !== undefined) {
parent.classList.add('scaffold-content-navigation-expanded');
parent.classList.add('scaffold-content-navigation-available');
const selectedElement = container.querySelector('[data-component="' + component + '"]') as HTMLElement;
if (selectedElement) {
// Re-set to the display setting from CSS
selectedElement.style.display = null;
}
parent.classList.add('scaffold-content-navigation-expanded');
parent.classList.add('scaffold-content-navigation-available');
const selectedElement = container.querySelector('[data-component="' + component + '"]') as HTMLElement;
if (selectedElement) {
// Re-set to the display setting from CSS
selectedElement.style.display = null;
}
}

Expand Down

0 comments on commit 0e05189

Please sign in to comment.