Skip to content

Commit

Permalink
[BUGFIX] Correct horizontal scrolling in iframe on iOS browsers
Browse files Browse the repository at this point in the history 
Browsers on iOS are ignoring the width property for iframes,
this resulted in iframes beeing rendered too wide and prevented
scrolling on the horizontal axis.

Resolves: #83841
Releases: master, 8.7
Change-Id: I825d6f911959fdb588f1f164f0ec4bbbf5c067c0
Reviewed-on: https://review.typo3.org/55649
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
  • Loading branch information
@benjaminkott
Benjamin Kott authored and benjaminkott committed Feb 10, 2018
1 parent 8bea912 commit 104cee4
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion Build/Resources/Public/Sass/scaffold/_scaffold.scss
View file
Expand Up @@ -166,7 +166,8 @@ body {
display: block;
border: none;
height: 100%;
width: 100%;
width: 1px;
min-width: 100%;
}

.scaffold-content-navigation {
Expand Down
4 changes: 2 additions & 2 deletions typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html
View file
Expand Up @@ -10,11 +10,11 @@
<div class="scaffold-content t3js-scaffold-content">
<div class="scaffold-content-navigation t3js-scaffold-content-navigation">
<div class="scaffold-content-navigation-component" data-component="typo3-navigationIframe">
<iframe name="nav_frame" src="about:blank" id="typo3-navigationContainerIframe" class="scaffold-content-navigation-iframe t3js-scaffold-content-navigation-iframe"></iframe>
<iframe name="nav_frame" src="about:blank" id="typo3-navigationContainerIframe" scrolling="no" class="scaffold-content-navigation-iframe t3js-scaffold-content-navigation-iframe"></iframe>
</div>
</div>
<div class="scaffold-content-module t3js-scaffold-content-module">
<iframe name="list_frame" id="typo3-contentIframe" class="scaffold-content-module-iframe t3js-scaffold-content-module-iframe"></iframe>
<iframe name="list_frame" id="typo3-contentIframe" scrolling="no" class="scaffold-content-module-iframe t3js-scaffold-content-module-iframe"></iframe>

This comment has been minimized.

Sign in to view

Copy link
@krisraich

krisraich Apr 3, 2018

That disabled scrolling in my App. Can you make this optional?

This comment has been minimized.

Sign in to view

Copy link
@benjaminkott

benjaminkott Apr 3, 2018 •
edited

Member

Please create a forge issue, and describe the issue so we are able to reproduce it.
You can assign this one directly to me, so i can have a look.
https://forge.typo3.org/projects/typo3cms-core

This comment has been minimized.

Sign in to view

Copy link
@helhum

helhum Apr 3, 2018

Contributor

@krisraich could it be, that you introduce custom CSS, that does not work with this fix?
Seems we cannot reproduce any misbehaviour in a blank TYPO3 install.

If you have steps to reproduce, please add a ticket here: https://forge.typo3.org/projects/typo3cms-core/issues

This comment has been minimized.

Sign in to view

Copy link
@krisraich

krisraich Apr 3, 2018

@helhum yes, i use a custom layout indeed. I've fixed it by now. But it seems that there is still some strange behaviour with scrolling, especially with Chrome.

@benjaminkott The issue is quite similar to issue No. 84476 and also my fault. Therefore, i won't open a new one.

This comment has been minimized.

Sign in to view

Copy link
@BastianBalthasarBux

BastianBalthasarBux Apr 3, 2018 •
edited

I personally just removed the "scrolling=no" from the iframes, that fixes the scrolling issues on latest Firefox versions with TYPO3 8.7.12.
No custom CSS.
Reproduction: use EXT:phpmyadmin in Firefox 59 (maybe also FF 58, AFAIR).
[Note: I don't know, if phpmyadmin uses custom css, that concerns that iframes, although I doubt it.]
Just if someone is curious ...
</div>
<div class="scaffold-content-overlay t3js-scaffold-content-overlay"></div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion typo3/sysext/backend/Resources/Public/Css/backend.css
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion typo3/sysext/install/Resources/Public/Css/install.css
View file

Large diffs are not rendered by default.

0 comments on commit 104cee4

Please sign in to comment.