[TASK] Make sysext/form/Tests/Unit/Mvc/ notice free

Releases: master Resolves: #84401 Change-Id: I59cd08acbae46abb5da0202bd719857594aa9439 Reviewed-on: https://review.typo3.org/56276 Tested-by: TYPO3com <no-reply@typo3.com> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
TYPO3 · Mar 17, 2018 · 10b15c4 · 10b15c4
1 parent 76dae7a
commit 10b15c4
Show file tree

Hide file tree

Showing 5 changed files with 74 additions and 69 deletions.
diff --git a/typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php b/typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php
@@ -56,7 +56,7 @@ public function afterBuildingFinished(RenderableInterface $renderable)
 
             $allowedMimeTypes = [];
             $validators = [];
-            if (is_array($renderable->getProperties()['allowedMimeTypes'])) {
+            if (isset($renderable->getProperties()['allowedMimeTypes']) && \is_array($renderable->getProperties()['allowedMimeTypes'])) {
                 $allowedMimeTypes = array_filter($renderable->getProperties()['allowedMimeTypes']);
             }
             if (!empty($allowedMimeTypes)) {

diff --git a/typo3/sysext/form/Tests/Unit/Mvc/Configuration/InheritancesResolverServiceTest.php b/typo3/sysext/form/Tests/Unit/Mvc/Configuration/InheritancesResolverServiceTest.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types = 1);
 namespace TYPO3\CMS\Form\Tests\Unit\Mvc\Configuration;
 
 /*
@@ -16,17 +17,13 @@
 
 use TYPO3\CMS\Form\Mvc\Configuration\Exception\CycleInheritancesException;
 use TYPO3\CMS\Form\Mvc\Configuration\InheritancesResolverService;
+use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
 /**
  * Test case
  */
-class InheritancesResolverServiceTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
+class InheritancesResolverServiceTest extends UnitTestCase
 {
-    /**
-     * Subject is not notice free, disable E_NOTICES
-     */
-    protected static $suppressNotices = true;
-
     /**
      * @var InheritancesResolverService
      */
@@ -41,7 +38,7 @@ protected function setUp()
      * @test
      * Test for the explicit example in service class comment
      */
-    public function getDocExampleInheritance()
+    public function getDocExampleInheritance(): void
     {
         $input = [
             'Form' => [
@@ -80,7 +77,7 @@ public function getDocExampleInheritance()
     /**
      * @test
      */
-    public function getMergedConfigurationSimpleInheritance()
+    public function getMergedConfigurationSimpleInheritance(): void
     {
         $input = [
             'Form' => [
@@ -121,7 +118,7 @@ public function getMergedConfigurationSimpleInheritance()
     /**
      * @test
      */
-    public function getMergedConfigurationSimpleInheritanceOverrideValue()
+    public function getMergedConfigurationSimpleInheritanceOverrideValue(): void
     {
         $input = [
             'Form' => [
@@ -154,7 +151,7 @@ public function getMergedConfigurationSimpleInheritanceOverrideValue()
     /**
      * @test
      */
-    public function getMergedConfigurationSimpleInheritanceRemoveValue()
+    public function getMergedConfigurationSimpleInheritanceRemoveValue(): void
     {
         $input = [
             'Form' => [
@@ -219,7 +216,7 @@ public function getMergedConfigurationSimpleInheritanceRemoveValue()
     /**
      * @test
      */
-    public function getMergedConfigurationSimpleMixin()
+    public function getMergedConfigurationSimpleMixin(): void
     {
         $input = [
             'Form' => [
@@ -263,7 +260,7 @@ public function getMergedConfigurationSimpleMixin()
     /**
      * @test
      */
-    public function getMergedConfigurationAdvancedMixin()
+    public function getMergedConfigurationAdvancedMixin(): void
     {
         $input = [
             'Form' => [
@@ -356,7 +353,7 @@ public function getMergedConfigurationAdvancedMixin()
     /**
      * @test
      */
-    public function getResolvedConfigurationThrowsExceptionIfCycleDepenciesOnSameLevelIsFound()
+    public function getResolvedConfigurationThrowsExceptionIfCycleDepenciesOnSameLevelIsFound(): void
     {
         $input = [
             'TYPO3' => [
@@ -386,7 +383,7 @@ public function getResolvedConfigurationThrowsExceptionIfCycleDepenciesOnSameLev
     /**
      * @test
      */
-    public function getResolvedConfigurationThrowsExceptionIfCycleDepenciesOnSameLevelWithGapIsFound()
+    public function getResolvedConfigurationThrowsExceptionIfCycleDepenciesOnSameLevelWithGapIsFound(): void
     {
         $input = [
             'TYPO3' => [
@@ -426,7 +423,7 @@ public function getResolvedConfigurationThrowsExceptionIfCycleDepenciesOnSameLev
     /**
      * @test
      */
-    public function getResolvedConfigurationThrowsExceptionIfCycleDepenciesOnHigherLevelIsFound()
+    public function getResolvedConfigurationThrowsExceptionIfCycleDepenciesOnHigherLevelIsFound(): void
     {
         $input = [
             'TYPO3' => [