Skip to content

Commit

Permalink
[TASK] Temporarly avoid PHPStan composer-max tests fails
Browse files Browse the repository at this point in the history
PHPStan fails with composer max installation due
changes in the detection. Raising the version to
corresponding version leads to abnormal performance
decrease. Thus not an option we can use.

This change pins phpstan to a fixed version to avoid
failing nightlies until the performance issue in the
PHPStan tool has been fixed.

See: phpstan/phpstan#7903

Used commands:

> composer req --dev "phpstan/phpstan":"1.8.2"

Resolves: #98253
Releases: main, 11.5
Change-Id: I38a31b87c36b9ae4c5915422dd3f09a6fca38b57
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75600
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
  • Loading branch information
sbuerk committed Sep 2, 2022
1 parent 8bfd84d commit 1354558
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -111,7 +111,7 @@
"php-webdriver/webdriver": "^1.12.1",
"phpspec/prophecy": "^1.15.0",
"phpspec/prophecy-phpunit": "^2.0.1",
"phpstan/phpstan": "^1.8.2",
"phpstan/phpstan": "1.8.2",
"phpstan/phpstan-phpunit": "^1.1.1",
"phpunit/phpunit": "^9.5.21",
"typo3/cms-styleguide": "~12.0@dev",
Expand Down
2 changes: 1 addition & 1 deletion composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1354558

Please sign in to comment.