Skip to content

Commit

Permalink
[TASK] Make AreaTest notice free
Browse files Browse the repository at this point in the history
Resolves: 84436
Releases: master
Change-Id: Ie882198724aaa3d77f695e036599dee3a1211938
Reviewed-on: https://review.typo3.org/56308
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
  • Loading branch information
Łukasz Uznański authored and lolli42 committed Mar 17, 2018
1 parent 4a6fa2a commit 1d71cf7
Showing 1 changed file with 4 additions and 9 deletions.
Expand Up @@ -23,15 +23,10 @@

class AreaTest extends UnitTestCase
{
/**
* Subject is not notice free, disable E_NOTICES
*/
protected static $suppressNotices = true;

/**
* @test
*/
public function makeRelativeToFileReducesSizes()
public function makeRelativeToFileReducesSizes(): void
{
$imageArea = new Area(50.0, 50.0, 100.0, 100.0);
$imageFixture = new File(
Expand All @@ -49,7 +44,7 @@ public function makeRelativeToFileReducesSizes()
$this->assertSame($expectedResult, $relativeArea->asArray());
}

public function applyRatioRestrictsAreaToRespectRatioDataProvider()
public function applyRatioRestrictsAreaToRespectRatioDataProvider(): array
{
return [
[
Expand Down Expand Up @@ -77,7 +72,7 @@ public function applyRatioRestrictsAreaToRespectRatioDataProvider()
* @test
* @dataProvider applyRatioRestrictsAreaToRespectRatioDataProvider
*/
public function applyRatioRestrictsAreaToRespectRatio(array $areaSize, $ratio)
public function applyRatioRestrictsAreaToRespectRatio(array $areaSize, $ratio): void
{
$area = new Area(...$areaSize);
$ratioFixture = new Ratio('dummy', 'dummy', $ratio);
Expand All @@ -88,7 +83,7 @@ public function applyRatioRestrictsAreaToRespectRatio(array $areaSize, $ratio)
/**
* @test
*/
public function applyRatioDoesNothingForFreeRatio()
public function applyRatioDoesNothingForFreeRatio(): void
{
$area = new Area(0.1, 0.1, 0.2, 0.4);
$ratioFixture = new Ratio('dummy', 'dummy', 0.0);
Expand Down

0 comments on commit 1d71cf7

Please sign in to comment.