Skip to content

Commit

Permalink
[BUGFIX] Use correctly terminated HTML block elements
Browse files Browse the repository at this point in the history
Using `<div />` as template to be used in jQuery worked previously,
but is not supported with jQuery 3.5.x anymore. Occurences are now
using correct expanded tags like `<div></div>`.

Resolves: #91367
Releases: master, 9.5
Change-Id: I088481e607b4621e28550f79f065496c89b409d1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64479
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Sebastien Convers <sebastien.convers@agrosupdijon.fr>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
  • Loading branch information
ohader committed May 14, 2020
1 parent dab027b commit 2398785
Show file tree
Hide file tree
Showing 17 changed files with 39 additions and 39 deletions.
Expand Up @@ -2,12 +2,12 @@
<div class="form-editor">
<div class="t3-form-control-group form-group">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1">
<span data-template-property="label" />
<span data-template-property="label"></span>
<div class="t3-form-controls" data-identifier="inspectorEditorControlsWrapper">
<input data-random-id data-random-id-attribute="id" data-random-id-number="1" type="checkbox" />
</div>
</label>
<span class="inspector-editor-hint" data-template-property="fieldExplanationText" />
<span class="inspector-editor-hint" data-template-property="fieldExplanationText"></span>
</div>
</div>
</html>
@@ -1,7 +1,7 @@
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<div class="t3-form-validator-editor">
<h4 data-template-property="header-label">
<span data-template-property="label" />
<span data-template-property="label"></span>
</h4>
</div>
</html>
Expand Up @@ -2,10 +2,10 @@
<div class="form-editor">
<div class="t3-form-control-group form-group">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1">
<span data-template-property="label" />
<span data-template-property="label"></span>
</label>
<div id="t3-form-add-finisher" class="t3-form-add-collection-element">
<select data-random-id data-random-id-attribute="id" data-random-id-number="1" data-template-property="selectOptions" class="form-control" />
<select data-random-id data-random-id-attribute="id" data-random-id-number="1" data-template-property="selectOptions" class="form-control"></select>
</div>
</div>
</div>
Expand Down
@@ -1,17 +1,17 @@
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<div class="form-editor">
<div class="t3-form-control-group form-group" data-identifier="editorWrapper">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label" /></label><br>
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label"></span></label><br>
<div class="t3-form-controls btn-group" data-identifier="inspectorEditorControlsWrapper">
<button type="button" class="btn btn-default" data-identifier="viewportButton"></button>
</div>
</div>
<div class="t3-form-control-group form-group" data-template-property="numbersOfColumnsToUse">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="numbersOfColumnsToUse-label" /></label>
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="numbersOfColumnsToUse-label"></span></label>
<div class="t3-form-controls" data-identifier="numbersOfColumnsToUse-inspectorEditorControlsWrapper">
<input data-random-id data-random-id-attribute="id" data-random-id-number="1" type="number" value="" data-template-property="numbersOfColumnsToUse-propertyPath" class="form-control">
</div>
<span data-template-property="numbersOfColumnsToUse-fieldExplanationText" />
<span data-template-property="numbersOfColumnsToUse-fieldExplanationText"></span>
</div>
</div>
</html>
Expand Up @@ -5,7 +5,7 @@
<f:if condition="{formvh:be.maximumFileSize()} > 0">
<div class="t3-form-validator-editor">
<div data-template-property="header-label" class="t3-form-control-group">
<span data-template-property="label" data-maximumFileSize="{formvh:be.maximumFileSize()}" class="inspector-editor-hint" />
<span data-template-property="label" data-maximumFileSize="{formvh:be.maximumFileSize()}" class="inspector-editor-hint"></span>
</div>
</div>
</f:if>
Expand Down
@@ -1,8 +1,8 @@
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<div class="t3-form-control-group form-group">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label" /></label>
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label"></span></label>
<div class="t3-form-controls" data-identifier="inspectorEditorControlsWrapper">
<select data-random-id data-random-id-attribute="id" data-random-id-number="1" data-template-property="selectOptions" class="form-control" multiple="multiple" />
<select data-random-id data-random-id-attribute="id" data-random-id-number="1" data-template-property="selectOptions" class="form-control" multiple="multiple"></select>
</div>
</div>
</html>
@@ -1,7 +1,7 @@
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<div class="form-editor">
<div class="t3-form-control-group form-group property-grid">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label" /></label>
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label"></span></label>
<div data-editor="new-property-grid" data-template-property="newPropertyPath">
<table class="table table-hover" data-identifier="propertyGridContainer">
<thead>
Expand Down Expand Up @@ -39,9 +39,9 @@
</tbody>
</table>
</div>
<div data-editor="property-grid" data-template-property="propertyPath" class="t3-form-grid" />
<span class="inspector-editor-hint" data-template-property="fieldExplanationText" />
<span data-template-property="validationErrors" />
<div data-editor="property-grid" data-template-property="propertyPath" class="t3-form-grid"></div>
<span class="inspector-editor-hint" data-template-property="fieldExplanationText"></span>
<span data-template-property="validationErrors"></span>
</div>
</div>
</html>
Expand Up @@ -2,18 +2,18 @@
<div class="form-editor">
<div class="t3-form-control-group form-group" data-identifier="editorWrapper">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1">
<span data-template-property="label" />
<span data-template-property="label"></span>
<div class="t3-form-controls" data-identifier="inspectorEditorControlsWrapper">
<input data-random-id data-random-id-attribute="id" data-random-id-number="1" type="checkbox" />
</div>
</label>
</div>
<div class="t3-form-control-group form-group" data-template-property="validationErrorMessage">
<label data-random-id data-random-id-attribute="for" data-random-id-number="2"><span data-template-property="validationErrorMessage-label" /></label>
<label data-random-id data-random-id-attribute="for" data-random-id-number="2"><span data-template-property="validationErrorMessage-label"></span></label>
<div class="t3-form-controls" data-identifier="inspectorEditorControlsWrapper">
<input data-random-id data-random-id-attribute="id" data-random-id-number="2" type="text" value="" data-template-property="validationErrorMessage-propertyPath" class="form-control">
</div>
<span data-template-property="validationErrorMessage-fieldExplanationText" class="inspector-editor-hint" />
<span data-template-property="validationErrorMessage-fieldExplanationText" class="inspector-editor-hint"></span>
</div>
</div>
</html>
@@ -1,8 +1,8 @@
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<div class="t3-form-control-group form-group">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label" /></label>
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label"></span></label>
<div class="t3-form-controls" data-identifier="inspectorEditorControlsWrapper">
<select data-random-id data-random-id-attribute="id" data-random-id-number="1" data-template-property="selectOptions" class="form-control" />
<select data-random-id data-random-id-attribute="id" data-random-id-number="1" data-template-property="selectOptions" class="form-control"></select>
</div>
</div>
</html>
@@ -1,7 +1,7 @@
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<div class="form-editor">
<div class="t3-form-control-group form-group">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label" /></label>
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label"></span></label>
<div class="input-group" data-identifier="inspectorEditorControlsGroup">
<div class="t3-form-controls" data-identifier="inspectorEditorControlsWrapper">
<input data-random-id data-random-id-attribute="id" data-random-id-number="1" type="text" value="" data-template-property="propertyPath" class="form-control">
Expand All @@ -17,8 +17,8 @@
</span>
</span>
</div>
<span class="inspector-editor-hint" data-template-property="fieldExplanationText" />
<span data-template-property="validationErrors" />
<span class="inspector-editor-hint" data-template-property="fieldExplanationText"></span>
<span data-template-property="validationErrors"></span>
</div>
</div>
</html>
@@ -1,11 +1,11 @@
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<div class="form-editor">
<div class="t3-form-control-group form-group">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label" /></label>
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label"></span></label>
<div class="t3-form-controls" data-identifier="inspectorEditorControlsWrapper">
<textarea data-random-id data-random-id-attribute="id" data-random-id-number="1" data-template-property="propertyPath" class="form-control" />
<textarea data-random-id data-random-id-attribute="id" data-random-id-number="1" data-template-property="propertyPath" class="form-control"></textarea>
</div>
<span class="inspector-editor-hint" data-template-property="fieldExplanationText" />
<span class="inspector-editor-hint" data-template-property="fieldExplanationText"></span>
</div>
</div>
</html>
@@ -1,18 +1,18 @@
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<div class="form-editor">
<div class="t3-form-control-group form-group">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label" /></label>
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label"></span></label>
<div class="t3-form-controls" data-identifier="inspectorEditorControlsWrapper">
<input data-random-id data-random-id-attribute="id" data-random-id-number="1" type="text" value="" data-template-property="propertyPath" class="form-control" data-insert-target="">
<div class="help-block">
<a href="#" data-template-property="onclick" class="btn btn-default">
<span class="t3js-icon icon icon-size-small icon-state-default icon-mimetypes-x-content-text" data-identifier="mimetypes-x-content-text">
<span class="icon-markup" data-template-property="image" />
</span> <span data-template-property="buttonLabel" />
<span class="icon-markup" data-template-property="image"></span>
</span> <span data-template-property="buttonLabel"></span>
</a>
</div>
<span class="inspector-editor-hint" data-template-property="fieldExplanationText" />
<span data-template-property="validationErrors" />
<span class="inspector-editor-hint" data-template-property="fieldExplanationText"></span>
<span data-template-property="validationErrors"></span>
</div>
</div>
</div>
Expand Down
@@ -1,13 +1,13 @@
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<div class="form-editor">
<div class="t3-form-control-group form-group">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label" /></label>
<label data-random-id data-random-id-attribute="for" data-random-id-number="1"><span data-template-property="label"></span></label>
<div data-identifier="inspectorEditorControlsGroup">
<div class="t3-form-controls" data-identifier="inspectorEditorControlsWrapper">
<input data-random-id data-random-id-attribute="id" data-random-id-number="1" type="text" value="" data-template-property="propertyPath" class="form-control">
</div>
</div>
<span class="inspector-editor-hint" data-template-property="fieldExplanationText" />
<span class="inspector-editor-hint" data-template-property="fieldExplanationText"></span>
</div>
</div>
</html>
Expand Up @@ -2,10 +2,10 @@
<div class="form-editor">
<div class="t3-form-control-group form-group">
<label data-random-id data-random-id-attribute="for" data-random-id-number="1">
<span data-template-property="label" />
<span data-template-property="label"></span>
</label>
<div id="t3-form-add-validator" class="t3-form-add-collection-element" data-template-property="selectOptionsContainer">
<select data-random-id data-random-id-attribute="id" data-random-id-number="1" data-template-property="selectOptions" class="form-control" />
<select data-random-id data-random-id-attribute="id" data-random-id-number="1" data-template-property="selectOptions" class="form-control"></select>
</div>
</div>
</div>
Expand Down
Expand Up @@ -14,7 +14,7 @@
</div>
</div>
<div class="element-content">
<div data-template-property="properties.contentElementUid" />
<div data-template-property="properties.contentElementUid"></div>
</div>
</div>
<div class="t3-form-validator-info" data-identifier="validators">
Expand Down
Expand Up @@ -14,9 +14,9 @@
</div>
</div>
<div class="element-content">
<div data-template-property="properties.saveToFileMount" />
<div data-template-property="properties.saveToFileMount"></div>
<div data-identifier="multiValueContainer" data-template-property="properties.allowedMimeTypes">
<div data-template-property="_value" />
<div data-template-property="_value"></div>
</div>
</div>
</div>
Expand Down
Expand Up @@ -14,7 +14,7 @@
</div>
</div>
<div class="element-content">
<div data-template-property="properties.text" />
<div data-template-property="properties.text"></div>
</div>
</div>
<div class="t3-form-validator-info" data-identifier="validators">
Expand Down

0 comments on commit 2398785

Please sign in to comment.