[TASK] Make MethodArgumentRequiredStaticMatcherTest notice free

Releases: master Resolves: #84317 Change-Id: Ib758d64aa3613d7af4885338f8cf856412fbd6f9 Reviewed-on: https://review.typo3.org/56190 Tested-by: TYPO3com <no-reply@typo3.com> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
TYPO3 · Mar 15, 2018 · 2ef7403 · 2ef7403
1 parent 0c8ea1f
commit 2ef7403
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/...stall/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcherTest.php b/...stall/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcherTest.php
@@ -26,11 +26,6 @@
  */
 class MethodArgumentRequiredStaticMatcherTest extends UnitTestCase
 {
-    /**
-     * Subject is not notice free, disable E_NOTICES
-     */
-    protected static $suppressNotices = true;
-
     /**
      * @test
      */
@@ -70,7 +65,7 @@ public function hitsFromFixtureAreFound()
     /**
      * @return array
      */
-    public function matchesReturnsExpectedRestFilesDataProvider()
+    public function matchesReturnsExpectedRestFilesDataProvider(): array
     {
         return [
             'two rest candidates with same number of arguments' => [
@@ -202,6 +197,9 @@ public function matchesReturnsExpectedRestFilesDataProvider()
     /**
      * @test
      * @dataProvider matchesReturnsExpectedRestFilesDataProvider
+     * @param array $configuration
+     * @param string $phpCode
+     * @param array $expected
      */
     public function matchesReturnsExpectedRestFiles(array $configuration, string $phpCode, array $expected)
     {
@@ -215,6 +213,10 @@ public function matchesReturnsExpectedRestFiles(array $configuration, string $ph
         $traverser->traverse($statements);
 
         $result = $subject->getMatches();
-        $this->assertEquals($expected[0]['restFiles'], $result[0]['restFiles']);
+        if (isset($expected[0], $result[0])) {
+            $this->assertEquals($expected[0]['restFiles'], $result[0]['restFiles']);
+        } else {
+            $this->assertEquals($expected, $result);
+        }
     }
 }