Skip to content

Commit

Permalink
[BUGFIX] Provide colPos for each cell in defLangBinding view
Browse files Browse the repository at this point in the history
When dragging content elements in page module, the colPos
value of the dragged element is updated based on the dropped
area. A drop area is a table cell `td` in which the elements are
placed as `div`. The cell itself has the colPos set via a data
attribute. This means moving an element (`div`) to another
cell (`td`), the element gets updated with the colPos of the
new cell.

This did not work if `defLangBinding` was activated because
all elements are then assigned to separate cells which missed
the colPos information completely.

The colPos information is now added to all cells in the
`defLangBinding` view.

Resolves: #92454
Releases: master, 10.4, 9.5
Change-Id: I1ab5cb0b3dd5574b6d3397dc52397365dc59d1ee
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66393
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
  • Loading branch information
o-ba authored and bmack committed Nov 4, 2020
1 parent 206cd37 commit 39663f2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions typo3/sysext/backend/Classes/View/PageLayoutView.php
Expand Up @@ -867,8 +867,8 @@ protected function generateLanguageView(
}
$out .= '
<tr>
<td valign="top" class="t3-grid-cell">' . implode('</td>
<td valign="top" class="t3-grid-cell">', $cCont) . '</td>
<td valign="top" class="t3-grid-cell" data-colpos="' . $cKey . '">' . implode('</td>
<td valign="top" class="t3-grid-cell" data-colpos="' . $cKey . '">', $cCont) . '</td>
</tr>';
}
}
Expand Down

0 comments on commit 39663f2

Please sign in to comment.