Skip to content

Commit

Permalink
[TASK] Replace prophecy in EXT:core ProcessorRegistryTest
Browse files Browse the repository at this point in the history
Resolves: #98743
Releases: main
Change-Id: Ifd7de886f9aa8684161139aae16b5667cb863c03
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76375
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
  • Loading branch information
nhovratov committed Nov 2, 2022
1 parent 3d59067 commit 3e10dc2
Showing 1 changed file with 10 additions and 13 deletions.
Expand Up @@ -17,16 +17,13 @@

namespace TYPO3\CMS\Core\Tests\Unit\Resource\Processing;

use Prophecy\PhpUnit\ProphecyTrait;
use TYPO3\CMS\Core\Resource\Processing\AbstractTask;
use TYPO3\CMS\Core\Resource\Processing\LocalImageProcessor;
use TYPO3\CMS\Core\Resource\Processing\ProcessorRegistry;
use TYPO3\TestingFramework\Core\Unit\UnitTestCase;

class ProcessorRegistryTest extends UnitTestCase
{
use ProphecyTrait;

protected bool $resetSingletonInstances = true;

/**
Expand All @@ -40,11 +37,11 @@ public function getProcessorWhenOnlyOneIsRegistered(): void
],
];
$subject = new ProcessorRegistry();
$taskMock = $this->prophesize(AbstractTask::class);
$taskMock->getType()->willReturn('Image');
$taskMock->getName()->willReturn('CropScaleMask');
$taskMock = $this->createMock(AbstractTask::class);
$taskMock->method('getType')->willReturn('Image');
$taskMock->method('getName')->willReturn('CropScaleMask');

$processor = $subject->getProcessorByTask($taskMock->reveal());
$processor = $subject->getProcessorByTask($taskMock);

self::assertInstanceOf(LocalImageProcessor::class, $processor);
}
Expand All @@ -57,7 +54,7 @@ public function getProcessorWhenNoneIsRegistered(): void
$this->expectExceptionCode(1560876294);

$subject = new ProcessorRegistry();
$taskMock = $this->prophesize(AbstractTask::class)->reveal();
$taskMock = $this->createMock(AbstractTask::class);
$subject->getProcessorByTask($taskMock);
}

Expand All @@ -75,12 +72,12 @@ public function getProcessorWhenSameProcessorIsRegisteredTwice(): void
'after' => 'LocalImageProcessor',
],
];
$subject = new ProcessorRegistry();
$taskMock = $this->prophesize(AbstractTask::class);
$taskMock->getType()->willReturn('Image');
$taskMock->getName()->willReturn('CropScaleMask');
$subject = new ProcessorRegistry();
$taskMock = $this->createMock(AbstractTask::class);
$taskMock->method('getType')->willReturn('Image');
$taskMock->method('getName')->willReturn('CropScaleMask');

$processor = $subject->getProcessorByTask($taskMock->reveal());
$processor = $subject->getProcessorByTask($taskMock);

self::assertInstanceOf(LocalImageProcessor::class, $processor);
}
Expand Down

0 comments on commit 3e10dc2

Please sign in to comment.