[TASK] Correct the semantic structure of headings in some card views

Several H1 headings are used in some card views. As a result, the semantic structure for these views is not correct. The relevant H1 headings are changed to h2. Resolves: #101545 Releases: main, 12.4 Change-Id: Ic53d92a52b1ae75adda18a63bc76633d7ffcfa44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80227 Tested-by: Jasmina Lie�mann <minapokhalo+typo3@gmail.com> Reviewed-by: Jasmina Lie�mann <minapokhalo+typo3@gmail.com> Tested-by: core-ci <typo3@b13.com>
TYPO3 · Aug 3, 2023 · 3e275b6 · 3e275b6
1 parent dd65908
commit 3e275b6
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 32 deletions.
diff --git a/typo3/sysext/backend/Resources/Private/Templates/Mfa/Overview.html b/typo3/sysext/backend/Resources/Private/Templates/Mfa/Overview.html
@@ -51,7 +51,7 @@ <h1><f:translate key="LLL:EXT:backend/Resources/Private/Language/locallang_mfa.x
                 <core:icon identifier="{provider.iconIdentifier}" size="large"/>
             </div>
             <div class="card-header-body">
-                <h1 class="card-title">
+                <h2 class="card-title">
                     {providerTitle}
                     <be:mfa.ifHasState state="active" provider="{provider}">
                         <span class="badge badge-{be:mfa.ifHasState(state: 'locked', provider: provider, then: 'danger', else: 'success')}">
@@ -63,7 +63,7 @@ <h1 class="card-title">
                             <core:icon identifier="actions-star" />
                         </span>
                     </f:if>
-                </h1>
+                </h2>
             </div>
         </div>
         <div class="card-body">

diff --git a/typo3/sysext/core/Tests/Acceptance/Application/InstallTool/LoginCest.php b/typo3/sysext/core/Tests/Acceptance/Application/InstallTool/LoginCest.php
@@ -43,48 +43,48 @@ public function installToolLogin(ApplicationTester $I): void
         $I->amGoingTo('assert page Maintenance contains the 8 expected cards');
         $I->click('Maintenance');
         $I->see('Maintenance', 'h1');
-        $I->see('Flush TYPO3 and PHP Cache', 'h1.card-title');
-        $I->see('Analyze Database Structure', 'h1.card-title');
-        $I->see('Remove Temporary Assets', 'h1.card-title');
-        $I->see('Rebuild PHP Autoload Information', 'h1.card-title');
-        $I->see('Clear Persistent Database Tables', 'h1.card-title');
-        $I->see('Create Administrative User', 'h1.card-title');
-        $I->see('Reset Backend User Preferences', 'h1.card-title');
-        $I->see('Manage Language Packs', 'h1.card-title');
+        $I->see('Flush TYPO3 and PHP Cache', 'h2.card-title');
+        $I->see('Analyze Database Structure', 'h2.card-title');
+        $I->see('Remove Temporary Assets', 'h2.card-title');
+        $I->see('Rebuild PHP Autoload Information', 'h2.card-title');
+        $I->see('Clear Persistent Database Tables', 'h2.card-title');
+        $I->see('Create Administrative User', 'h2.card-title');
+        $I->see('Reset Backend User Preferences', 'h2.card-title');
+        $I->see('Manage Language Packs', 'h2.card-title');
         $I->seeNumberOfElements('.card', 8);
 
         $I->amGoingTo('assert page Settings contains the 6 expected cards');
         $I->click('Settings');
         $I->see('Settings', 'h1');
-        $I->see('Extension Configuration', 'h1.card-title');
-        $I->see('Change Install Tool Password', 'h1.card-title');
-        $I->see('Manage System Maintainers', 'h1.card-title');
-        $I->see('Configuration Presets', 'h1.card-title');
-        $I->see('Feature Toggles', 'h1.card-title');
-        $I->see('Configure Installation-Wide Options', 'h1.card-title');
+        $I->see('Extension Configuration', 'h2.card-title');
+        $I->see('Change Install Tool Password', 'h2.card-title');
+        $I->see('Manage System Maintainers', 'h2.card-title');
+        $I->see('Configuration Presets', 'h2.card-title');
+        $I->see('Feature Toggles', 'h2.card-title');
+        $I->see('Configure Installation-Wide Options', 'h2.card-title');
         $I->seeNumberOfElements('.card', 6);
 
         $I->amGoingTo('assert page Upgrade contains the 7 expected cards');
         $I->click('Upgrade');
         $I->see('Upgrade', 'h1');
-        $I->see('Update TYPO3 Core', 'h1.card-title');
-        $I->see('Upgrade Wizard', 'h1.card-title');
-        $I->see('View Upgrade Documentation', 'h1.card-title');
-        $I->see('Check TCA in ext_tables.php', 'h1.card-title');
-        $I->see('Check for Broken Extensions', 'h1.card-title');
-        $I->see('Check TCA Migrations', 'h1.card-title');
-        $I->see('Scan Extension Files', 'h1.card-title');
+        $I->see('Update TYPO3 Core', 'h2.card-title');
+        $I->see('Upgrade Wizard', 'h2.card-title');
+        $I->see('View Upgrade Documentation', 'h2.card-title');
+        $I->see('Check TCA in ext_tables.php', 'h2.card-title');
+        $I->see('Check for Broken Extensions', 'h2.card-title');
+        $I->see('Check TCA Migrations', 'h2.card-title');
+        $I->see('Scan Extension Files', 'h2.card-title');
         $I->seeNumberOfElements('.card', 7);
 
         $I->amGoingTo('assert page Environment contains the 6 expected cards');
         $I->click('Environment');
         $I->see('Environment', 'h1');
-        $I->see('Environment Overview', 'h1.card-title');
-        $I->see('Environment Status', 'h1.card-title');
-        $I->see('Directory Status', 'h1.card-title');
-        $I->see('PHP Info', 'h1.card-title');
-        $I->see('Test Mail Setup', 'h1.card-title');
-        $I->see('Image Processing', 'h1.card-title');
+        $I->see('Environment Overview', 'h2.card-title');
+        $I->see('Environment Status', 'h2.card-title');
+        $I->see('Directory Status', 'h2.card-title');
+        $I->see('PHP Info', 'h2.card-title');
+        $I->see('Test Mail Setup', 'h2.card-title');
+        $I->see('Image Processing', 'h2.card-title');
         $I->seeNumberOfElements('.card', 6);
     }
 }
diff --git a/typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js b/typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js
@@ -125,7 +125,7 @@ function factory($, Modal, Severity, MultiStepWizard, Icons, Notification, Secur
                   + '<div class="card-header">'
                   + '<div class="card-icon">' + blankIconMarkup + '</div>'
                   + '<div class="card-header-body">'
-                  + '<h1 class="card-title">' + TYPO3.lang['formManager.blankForm.label'] + '</h1>'
+                  + '<h2 class="card-title">' + TYPO3.lang['formManager.blankForm.label'] + '</h2>'
                   + '<span class="card-subtitle">' + TYPO3.lang['formManager.blankForm.subtitle'] + '</span>'
                   + '</div>'
                   + '</div>'
@@ -140,7 +140,7 @@ function factory($, Modal, Severity, MultiStepWizard, Icons, Notification, Secur
                   + '<div class="card-header">'
                   + '<div class="card-icon">' + duplicateIconMarkup + '</div>'
                   + '<div class="card-header-body">'
-                  + '<h1 class="card-title">' + TYPO3.lang['formManager.predefinedForm.label'] + '</h1>'
+                  + '<h2 class="card-title">' + TYPO3.lang['formManager.predefinedForm.label'] + '</h2>'
                   + '<span class="card-subtitle">' + TYPO3.lang['formManager.predefinedForm.subtitle'] + '</span>'
                   + '</div>'
                   + '</div>'

diff --git a/typo3/sysext/install/Resources/Private/Partials/Card/Header.html b/typo3/sysext/install/Resources/Private/Partials/Card/Header.html
@@ -7,7 +7,7 @@
     </f:if>
     <div class="card-header-body">
         <f:if condition="{title}">
-            <h1 class="card-title">{title}</h1>
+            <h2 class="card-title">{title}</h2>
         </f:if>
         <f:if condition="{subtitle}">
             <span class="card-subtitle">{subtitle}</span>