Skip to content

Commit

Permalink
[BUGFIX] Make reloadFrames() non-static
Browse files Browse the repository at this point in the history
This patch makes the reloadFrames() method non-static, as the method is
required in an instance context.

Resolves: #84323
Related: #82597
Releases: master
Change-Id: I3bdcfdc91721bb2c145fd42ae4448b09a72e636e
Reviewed-on: https://review.typo3.org/56202
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
  • Loading branch information
andreaskienast authored and NeoBlack committed Mar 16, 2018
1 parent 0340961 commit 417d2b5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
22 changes: 11 additions & 11 deletions typo3/sysext/backend/Resources/Private/TypeScript/ModuleMenu.ts
Expand Up @@ -35,11 +35,6 @@ class ModuleMenu {
private loadedModule: string = null;
private loadedNavigationComponentId: string = '';

public static reloadFrames(): void {
Viewport.NavigationContainer.refresh();
Viewport.ContentContainer.refresh();
}

/**
* Fetches all module menu elements in the local storage that should be collapsed
*
Expand Down Expand Up @@ -172,7 +167,15 @@ class ModuleMenu {
});
}


/**
* Reloads the frames
*
* Hint: This method can't be static (yet), as this must be bound to the ModuleMenu instance.
*/
public reloadFrames(): void {
Viewport.NavigationContainer.refresh();
Viewport.ContentContainer.refresh();
}

/**
* Event handler called after clicking on the module menu item
Expand Down Expand Up @@ -432,14 +435,11 @@ class ModuleMenu {
}
}

let moduleMenuApp;

if (!top.TYPO3.ModuleMenu) {
moduleMenuApp = top.TYPO3.ModuleMenu = {
top.TYPO3.ModuleMenu = {
App: new ModuleMenu()
};
} else {
moduleMenuApp = top.TYPO3.ModuleMenu;
}
const moduleMenuApp = top.TYPO3.ModuleMenu;

export = moduleMenuApp;

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 417d2b5

Please sign in to comment.