Skip to content

Commit

Permalink
[TASK] Remove a useless WorkspaceService test
Browse files Browse the repository at this point in the history
The test does not make sense and is skipped for a
while already. Remove it.

Resolves: #97112
Releases: main, 11.5
Change-Id: If00b0b607263531359393cff7793624a12b878bb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76743
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
  • Loading branch information
lolli42 authored and sbuerk committed Nov 20, 2022
1 parent 2796a33 commit 4853855
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 30 deletions.
5 changes: 0 additions & 5 deletions Build/phpstan/phpstan-baseline.neon
Expand Up @@ -5230,8 +5230,3 @@ parameters:
count: 1
path: ../../typo3/sysext/workspaces/Classes/Service/GridDataService.php

-
message: "#^Unreachable statement \\- code above always terminates\\.$#"
count: 1
path: ../../typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php

Expand Up @@ -113,31 +113,6 @@ public function versionsCanBeFilteredToSpecificStage(): void
self::assertEquals(106, $result['pages'][1]['uid'], 'First records is supposed to have the uid 106');
}

/**
* The only change which we could find here actually moved away from this
* branch of the tree - therefore we're not supposed to find anything here
*
* @test
*/
public function movedElementsCanNotBeFoundAtTheirOrigin(): void
{
self::markTestSkipped('This test need a review. It is green even if all fixtures are commented out');
$this->importCSVDataSet(__DIR__ . '/Fixtures/WorkspaceServiceTestMovedContent.csv');
// Test if the placeholder can be found when we ask using recursion (same result)
$service = new WorkspaceService();
$result = $service->selectVersionsInWorkspace(91, -99, 2, 99);
self::assertCount(
0,
$result['pages'],
'Changes should not show up in this branch of the tree within workspace 91'
);
self::assertCount(
0,
$result['tt_content'],
'Changes should not show up in this branch of the tree within workspace 91'
);
}

/**
* @test
*/
Expand Down

0 comments on commit 4853855

Please sign in to comment.