Skip to content

Commit

Permalink
[DOCS] Fix grammatical errors
Browse files Browse the repository at this point in the history
Most fixes relate to indefinite article usage "an vs a" and some typos.

Resolves: #102074
Releases: main, 12.4, 11.5
Change-Id: Ief07759697828d94edde8902a912719f82b2b798
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81487
Tested-by: Benjamin Franzke <ben@bnf.dev>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Benjamin Franzke <ben@bnf.dev>
  • Loading branch information
simonschaufi authored and bnf committed Oct 20, 2023
1 parent bb6c710 commit 5023fe9
Show file tree
Hide file tree
Showing 111 changed files with 122 additions and 121 deletions.
Expand Up @@ -367,7 +367,7 @@ public function synchronizeLocalizeAction(ServerRequestInterface $request): Resp
// pick the uid field from the array ... Basically, we need the uid of the 'default language' record,
// since this is used in JS to locate and remove the 'shadowed' container.
// @todo: Find out if this is really necessary that sometimes ['databaseRow']['l10n_parent'][0]
// is resolved to a direct uid, and sometimes it's a array with items. Could this be harmonized?
// is resolved to a direct uid, and sometimes it's an array with items. Could this be harmonized?
$transOrigPointerFieldValue = $transOrigPointerFieldValue['uid'];
}
}
Expand Down
Expand Up @@ -120,7 +120,7 @@ public function updateProperties(array $properties): bool

/**
* Create a new provider entry for the current user
* Note: If a entry already exists, use updateProperties() instead.
* Note: If an entry already exists, use updateProperties() instead.
* This can be checked with hasProviderEntry().
*
* @param array $properties
Expand Down
2 changes: 1 addition & 1 deletion typo3/sysext/core/Classes/DataHandling/DataHandler.php
Expand Up @@ -3655,7 +3655,7 @@ public function copyRecord_raw($table, $uid, $pid, $overrideArray = [], array $w

// When a record is copied in workspace (eg. to create a delete placeholder record for a live record), records
// pointing to that record need a reference index update. This is for instance the case in FAL, if a sys_file_reference
// for a eg. tt_content record is marked as deleted. The tt_content record then needs a reference index update.
// that refers e.g. to a tt_content record is marked as deleted. The tt_content record then needs a reference index update.
// This scenario seems to currently only show up if in workspaces, so the refindex update is restricted to this for now.
if (!empty($workspaceOptions)) {
$this->referenceIndexUpdater->registerUpdateForReferencesToItem($table, (int)$row['uid'], (int)$this->BE_USER->workspace);
Expand Down
Expand Up @@ -275,7 +275,7 @@ public function notLike(string $fieldName, $value): string
}

/**
* Creates a IN () comparison expression with the given arguments.
* Creates an IN () comparison expression with the given arguments.
*
* @param string $fieldName The fieldname. Will be quoted according to database platform automatically.
* @param string|array $value The placeholder or the array of values to be used by IN() comparison.
Expand Down Expand Up @@ -587,7 +587,7 @@ public function max(string $fieldName, string $alias = null): string
}

/**
* Creates a AVG expression for the given field/alias.
* Creates an AVG expression for the given field/alias.
*
* @param string $fieldName
* @param string|null $alias
Expand Down
Expand Up @@ -304,7 +304,7 @@ public function parseCreateTableStatements(array $statements): array
/**
* doctrine/dbal detects both sqlite autoincrement variants (row_id alias and autoincrement) through assumptions
* which have been made. TYPO3 reads the ext_tables.sql files as MySQL/MariaDB variant, thus not setting the
* autoincrement value to true for the row_id alias variant, which leads to a endless missmatch during database
* autoincrement value to true for the row_id alias variant, which leads to an endless missmatch during database
* comparison. This method adopts the doctrine/dbal assumption and apply it to the meta schema to mitigate
* endless database compare detections in these cases.
*
Expand Down
Expand Up @@ -77,7 +77,7 @@ public function forceSortAndSavePackageStates()
}

/**
* Create PackageStates.php if missing and LocalConfiguration exists, used to have a Install Tool session running
* Create PackageStates.php if missing and LocalConfiguration exists, used to have an Install Tool session running
*
* It is fired if PackageStates.php is deleted on a running instance,
* all packages marked as "part of minimal system" are activated in this case.
Expand Down
Expand Up @@ -26,6 +26,7 @@ class JavaScriptModuleInstruction implements \JsonSerializable
* @todo In future versions this might be ES6 module as well
*/
public const FLAG_LOAD_REQUIRE_JS = 1;

/**
* Indicates all actions shall be applied globally to `top.window`.
*/
Expand Down
Expand Up @@ -26,7 +26,7 @@
* based on user or group configuration.
*
* We do not have AOP in TYPO3 for now, thus the aspect which
* deals with resource security is a EventListener which reacts on storage object creation.
* deals with resource security is an EventListener which reacts on storage object creation.
*
* @internal this is an Event Listener, and not part of TYPO3 Core API.
*/
Expand Down
Expand Up @@ -31,6 +31,6 @@ Any TYPO3 installation with an extension providing TCA with :php:`selicon_field_
Migration
=========

Remove the option :php:`selicon_field_path` and use a inline relation to file references in :php:`selicon_field` instead.
Remove the option :php:`selicon_field_path` and use an inline relation to file references in :php:`selicon_field` instead.

.. index:: TCA, PartiallyScanned, ext:core
Expand Up @@ -13,7 +13,7 @@ When indexing a page, the indexer of `Indexed search` previously kept the used c
used "cHashParams" for storing search entries. This is not necessary anymore, as Site Handling now
contains the relevant arguments already in the search entry as well. This can be removed now.

In addition, when setting up a Indexing configuration, the option to respect cHash is removed,
In addition, when setting up an Indexing configuration, the option to respect cHash is removed,
as this is done automatically when needed.

The public property :php:`TYPO3\CMS\IndexedSearch\Indexer->cHashParams` has been removed.
Expand Down
Expand Up @@ -12,7 +12,7 @@ Description
The short-hand method :php:`GeneralUtility::getUrl()` provides a
fast way to fetch the contents of a local file or remote URL.

For Remote URLs, TYPO3 v8 provides a object-oriented (PSR-7 compatible) way by using
For Remote URLs, TYPO3 v8 provides an object-oriented (PSR-7 compatible) way by using
the :php:`RequestFactory->request($url, $method, $options)` API. Under the hood, the PHP library GuzzleHTTP is used,
which evaluates what best option (e.g. curl library) should handle
the download to TYPO3.
Expand Down
Expand Up @@ -23,7 +23,7 @@ Components, this functionality will be marked as deprecated in later TYPO3 v11 r

The main benefit of the Folder Navigation based on the SVG tree is the enhanced
loading functionality. This way, the Folder Navigation has the exact same
look&feel as the Page Tree, and also now contains a always-enabled filter
look&feel as the Page Tree, and also now contains an always-enabled filter
on top of the Component, just as the Page Tree Navigation Component.


Expand Down
Expand Up @@ -18,7 +18,7 @@ backend.
The Record Selectors are used when e.g. choosing a :guilabel:`Target Page` for a
:guilabel:`Shortcut Page`, or selecting a :guilabel:`Storage Page` in a plugin.

The file selectors are used when choosing a file for a IRRE-based FAL-based
The file selectors are used when choosing a file for an IRRE-based FAL-based
file reference.

Link Pickers are used when linking to a specific page, content element, file,
Expand Down
Expand Up @@ -13,7 +13,7 @@ Extbase has the odd behavior that
:php:`\TYPO3\CMS\Extbase\DomainObject\DomainObjectInterface` objects -
typically classes in :file:`Classes/Domain/Model` of Extbase enabled
extensions - don't call :php:`__construct` when the persistence layer
"thaws" a model from database - typically when a Extbase
"thaws" a model from database - typically when an Extbase
:php:`Domain/Repository` uses a :php:`->findBy*` method.

As a side-effect of switching away from Extbase :php:`ObjectManager` towards
Expand Down
Expand Up @@ -49,7 +49,7 @@ The following methods are marked as deprecated. Calling these methods will trigg

Soft reference parsers must implement
:php:`TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserInterface`.
Otherwise a a PHP :php:`E_USER_DEPRECATED` error will be triggered and an exception will be thrown
Otherwise a PHP :php:`E_USER_DEPRECATED` error will be triggered and an exception will be thrown
in TYPO3 v12.

Affected Installations
Expand Down
Expand Up @@ -10,7 +10,7 @@ Description
===========

Some smtp-relay-server require to set the domain under which the sender is
sending a email. As default the EsmtpTransport from Symfony will use the current
sending an email. As default the EsmtpTransport from Symfony will use the current
domain/IP of the host or container. This will be sufficient for the most of the
servers but some servers requires a valid domain is passed. If this isn't done,
sending emails via such servers will fail.
Expand Down
Expand Up @@ -56,7 +56,7 @@ allows to load a file directly when interpreting the HTML of the
browser, instead of first interpreting the HTML, then the CSS
and have a blocking call to an external URL to continue interpreting the CSS.

It is recommended to use the :html:`<link>` tag or create a inlineCSS TypoScript
It is recommended to use the :html:`<link>` tag or create an inlineCSS TypoScript
manually to load such a file with the :css:`@import` syntax.

.. index:: TypoScript, NotScanned, ext:frontend
Expand Up @@ -11,7 +11,7 @@ Description
===========

The ClickMenu has seen some major changes under the hood. This implies some refactoring within JavaScript where existing
functionality is replaced by a AMD Module based on jQuery. The following JS methods are now replaced by respective
functionality is replaced by an AMD Module based on jQuery. The following JS methods are now replaced by respective
methods:

- showClickmenu_raw()
Expand Down
Expand Up @@ -10,7 +10,7 @@ See :issue:`65585`
Description
===========

TCA type `imageManipulation` brings a image manipulation wizard to the core.
TCA type `imageManipulation` brings an image manipulation wizard to the core.

This first version brings image cropping with the possibility to
set a certain aspect ratio for the cropped area. The
Expand Down
Expand Up @@ -37,7 +37,7 @@ Basic example:
Example of rendering a email template:
Example of rendering an email template:

.. code-block:: php
Expand Down
Expand Up @@ -11,7 +11,7 @@ Description
===========

The functionality of instantiating classes only once by calling `GeneralUtility::getUserObj($className)` multiple times
while having a `$className` that is prepended with a ampersand ("&") has been marked as deprecated.
while having a `$className` that is prepended with an ampersand ("&") has been marked as deprecated.


An example of the deprecated behaviour in the ext_localconf.php of an extension:
Expand Down
Expand Up @@ -12,7 +12,7 @@ Description

Before #56726 the metadata extraction was only called through the extract metadata
scheduler task.
So when a editor uploaded a new file he had to wait until the scheduler task had
So when an editor uploaded a new file he had to wait until the scheduler task had
been triggered again and extracted the metadata.

Now the metadata extraction is by default triggered after adding/uploading a file
Expand Down
Expand Up @@ -10,7 +10,7 @@ See :issue:`61799`
Description
===========

Editors can now use YouTube and Vimeo videos (online media) just like a any other file, organising them just like any
Editors can now use YouTube and Vimeo videos (online media) just like any other file, organising them just like any
other file in the file list and selecting them in element browser to use in a CE or any other record.
Adding new online media files is done providing the URL to online media. The matching helper class will fetch the
needed metadata and supply an image that will be used as preview if available.
Expand Down
Expand Up @@ -14,7 +14,7 @@ In order to comfortably render video, audio and all other file types with a regi
introduced with #61800) in FE, the `MediaViewHelper` has been added.

The `MediaViewHelper` first checks if there is a Renderer present for the given file. If not, it will as fallback
render a image tag. This way it is a replacement for the `ImageViewHelper` in most cases when rendering video and
render an image tag. This way it is a replacement for the `ImageViewHelper` in most cases when rendering video and
audio tags.

Examples:
Expand Down
Expand Up @@ -50,7 +50,7 @@ of them beforehand:
:php:`parseDataStructureByIdentifierPreProcess` to specify an own "identifier" syntax
and to resolve that syntax to a data structure later: flux_

* EXT:gridelements: Similar to flux, gridelements has a own logic to choose which specific
* EXT:gridelements: Similar to flux, gridelements has an own logic to choose which specific
data structure should be used. However, the data structures are located in database row fields,
so the "record" syntax of the core can be re-used to refer to those. gridelements uses the hook
:php:`getDataStructureIdentifierPreProcess` together with a small implementation in
Expand Down
Expand Up @@ -75,8 +75,8 @@ Modal.types.ajax
Content will be grabbed from a url set in the option `content`

Modal.types.iframe
Url provided in the option `content` will be loaded in a iframe in the modal.
Also it will automaticly set the title from the contained document.
Url provided in the option `content` will be loaded in an iframe in the modal.
Also it will automatically set the title from the contained document.


Title
Expand Down Expand Up @@ -216,9 +216,9 @@ Size

While the modal itself adapts to the window, there are several options available
to limit the maximal size of the modal. The sizes :js:`Modal.sizes.small` and the
default :js:`Modal.sizes.default` will automaticly adapt to the content and are only
default :js:`Modal.sizes.default` will automatically adapt to the content and are only
limited to the width of the modal. :js:`Modal.sizes.large` and :js:`Modal.sizes.full`
are designed to contain a undefined lenth of content in a fixed sized modal.
are designed to contain a undefined length of content in a fixed sized modal.
These are suited best for :js:`Modal.types.ajax` or :js:`Modal.types.iframe` content.

.. code-block:: javascript
Expand Down
Expand Up @@ -9,7 +9,7 @@ See :issue:`79777`
Description
===========

Instead of deleting the record directly in the database, a a "deleted" column was added for ``tx_scheduler_task``
Instead of deleting the record directly in the database, a "deleted" column was added for ``tx_scheduler_task``
in a way to have developers / admins revive a task later-on.


Expand Down
Expand Up @@ -38,7 +38,7 @@ Calling :php:`$TSFE->sendRedirect()`, :php:`$TSFE->updateMD5paramsRecord()` and
:php:`GeneralUtility::makeRedirectUrl()` will result in a fatal PHP error.

Accessing the now non-existent property :php:`$TSFE->RDCT` will trigger a PHP notice, as well
as setting up a new instance of `TypoScriptFrontendController` with a eighth parameter.
as setting up a new instance of `TypoScriptFrontendController` with an eighth parameter.

Accessing the database table `cache_md5params` will also lead to unexpected results as this table
does not exist in new installations anymore.
Expand Down
Expand Up @@ -50,7 +50,7 @@ Setting any of the PHP properties above will have no effect anymore.
Affected Installations
======================

Any TYPO3 installation with a extension accessing directly GraphicalFunctions or GifBuilder API
Any TYPO3 installation with an extension accessing directly GraphicalFunctions or GifBuilder API
via PHP and using any of the properties above.


Expand Down
Expand Up @@ -38,6 +38,6 @@ Migration
=========

Add the required parameters to the API calls in your extension registration files, typically
located within :file:`ext_localconf.php`, :file:`ext_tables.php` or :file:`Configuration/TCA/*` of a extension.
located within :file:`ext_localconf.php`, :file:`ext_tables.php` or :file:`Configuration/TCA/*` of an extension.

.. index:: PHP-API, PartiallyScanned
Expand Up @@ -33,7 +33,7 @@ Usage in TypeScript:
import Popover = require('TYPO3/CMS/Backend/Popover');
To use popovers in a amd module, add it as a dependency and a corresponding argument to the anonymous function:
To use popovers in an amd module, add it as a dependency and a corresponding argument to the anonymous function:

.. code-block:: javascript
Expand Down
Expand Up @@ -16,7 +16,7 @@ The following methods have been marked as deprecated in :php:`ExtensionManagemen
* :php:`removeCacheFiles()`

Additionally the second method parameter of :php:`ExtensionManagementUtility::isLoaded()` to
throw a exception when an extension is not loaded, has been marked as deprecated, and should not
throw an exception when an extension is not loaded, has been marked as deprecated, and should not
be used anymore.


Expand Down
Expand Up @@ -12,7 +12,7 @@ Description
The URL handler concept introduced in TYPO3 v7 to allow pages to do redirects has been deprecated in favor
of using PSR-7 / PSR-15 middlewares.

The Redirect URL handlers were used for e.g. jumpURLs, pages that should redirect to a external URL
The Redirect URL handlers were used for e.g. jumpURLs, pages that should redirect to an external URL
or special handlings registered via the :php:`\TYPO3\CMS\Frontend\Http\UrlHandlerInterface`.

All functionality and methods have been marked as deprecated and will be removed in TYPO3 v10.0.
Expand Down
Expand Up @@ -45,7 +45,7 @@ Impact
======

If an instance provides additional authentication services, and if one of that services does
not return correct authentication values, this may open a authentication bypass security issue
not return correct authentication values, this may open an authentication bypass security issue
when upgrading to TYPO3 v9.


Expand Down
Expand Up @@ -10,7 +10,7 @@ Description
===========

Rendering a Hierarchical Menu via TypoScript previously allowed various rendering methods, namely textual (`TMENU`),
but also rendering menu items as images (`GMENU`) or as a image map (`IMGMENU`). Both graphical possibilities
but also rendering menu items as images (`GMENU`) or as an image map (`IMGMENU`). Both graphical possibilities
have been marked as deprecated, as it is considered bad practice building websites
nowadays - images with a fixed width, and text within images has various drawbacks in terms of accessibility and
responsive renderings.
Expand Down
Expand Up @@ -8,7 +8,7 @@
</trans-unit>
<trans-unit id="totp.description" resname="totp.description">
<source>This provider allows to authenticate with a single-use passcode which is based on the current time.
Each code is only valid for 30 seconds. You need a OTP application or device, supporting such tokens.</source>
Each code is only valid for 30 seconds. You need an OTP application or device, supporting such tokens.</source>
</trans-unit>
<trans-unit id="totp.setupInstructions" resname="totp.setupInstructions">
<source>The time-based one-time password provider enables you to strengthen your accounts' security by requiring a six-digit code on every login.
Expand Down
Expand Up @@ -63,11 +63,11 @@ public function checkIfExpandsAndCollapseShowInput(ApplicationTester $I): void

public function hideAndUnhideInline1nInlineElement(ApplicationTester $I): void
{
$I->wantTo('Can hide a Inline Element');
$I->wantTo('Can hide an Inline Element');
$I->click('button span[data-identifier="actions-edit-hide"]', '[data-field-name^="[tx_styleguide_inline_1n_child]["]');
$I->waitForElement('[data-field-name^="[tx_styleguide_inline_1n_child]["].t3-form-field-container-inline-hidden');
$I->waitForElement('[data-field-name^="[tx_styleguide_inline_1n_child]["] button span[data-identifier="actions-edit-unhide"]');
$I->wantTo('Can unhide a Inline Element');
$I->wantTo('Can unhide an Inline Element');
$I->click('button span[data-identifier="actions-edit-unhide"]', '[data-field-name^="[tx_styleguide_inline_1n_child]["]');
$I->waitForElementNotVisible('[data-field-name^="[tx_styleguide_inline_1n_child]["].t3-form-field-container-inline-hidden', 2);
}
Expand Down

0 comments on commit 5023fe9

Please sign in to comment.