[TASK] Remove ErrorIconViewHelper and move logic into model and template

Simplify generation of the error icon by removing the ViewHelper and
generate the icon identifier in the model instead.

As the ViewHelper is no public API it can be removed without a RST file.

Resolves: #83945
Releases: master
Change-Id: I7515ff69a729ccb66288437f5236a1ce8fa591c1
Reviewed-on: https://review.typo3.org/55763
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>

typo3/sysext/belog/Classes/Domain/Model/LogEntry.php

@@ -278,6 +278,24 @@ public function getError()
         return (int)$this->error;
     }
 
+    /**
+     * Get class name for the error code
+     *
+     * @return string
+     */
+    public function getErrorIconClass(): string
+    {
+        switch ($this->getError()) {
+            case 1:
+                return 'status-dialog-warning';
+            case 2:
+            case 3:
+                return 'status-dialog-error';
+            default:
+                return 'empty-empty';
+        }
+    }
+
     /**
      * Set details
      *

typo3/sysext/belog/Resources/Private/Partials/Content/LogEntries.html

@@ -139,7 +139,9 @@ <h3>
 						<f:for each="{day}" as="logItem">
 							<tr>
 								<td>
-									<belog:ErrorIcon errorNumber="{logItem.error}"/>
+									<f:if condition="{logItem.errorIconClass}">
+										<core:icon identifier="{logItem.errorIconClass}" />
+									</f:if>
 								</td>
 								<td>
 									<f:format.date format="H:i:s">@{logItem.tstamp}</f:format.date>