Skip to content

Commit

Permalink
[BUGFIX] t3editor: Keep original flex configuration
Browse files Browse the repository at this point in the history
When t3editor got streamlined in the past, configuration for flex was
defined that conflicts with CodeMirror's internal style definition,
leading to UI glitches like "cut out" content, see screenshot attached
to the ticket..

This commit removes the conflicting CSS.

Resolves: #101442
Releases: main, 12.4
Change-Id: Ie5b9f8d498cdaef0b3455e05e247cb5fd64b0617
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83681
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Garvin Hicking <gh@faktor-e.de>
Reviewed-by: Garvin Hicking <gh@faktor-e.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
  • Loading branch information
andreaskienast committed Apr 7, 2024
1 parent 5079949 commit 6fe3cd8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
Expand Up @@ -104,12 +104,6 @@ export class CodeMirrorElement extends LitElement {
.cm-scroller {
min-height: 100%;
max-height: calc(100vh - 10rem);
flex: 1;
align-items: unset;
}
.ͼ1 .cm-scroller {
align-items: unset !important;
}
`;

Expand Down
Expand Up @@ -83,11 +83,5 @@ var __decorate=function(e,t,o,r){var i,a=arguments.length,l=a<3?t:null===r?r=Obj
.cm-scroller {
min-height: 100%;
max-height: calc(100vh - 10rem);
flex: 1;
align-items: unset;
}
.ͼ1 .cm-scroller {
align-items: unset !important;
}
`,__decorate([property({type:Object})],CodeMirrorElement.prototype,"mode",void 0),__decorate([property({type:Array})],CodeMirrorElement.prototype,"addons",void 0),__decorate([property({type:Array})],CodeMirrorElement.prototype,"keymaps",void 0),__decorate([property({type:Number})],CodeMirrorElement.prototype,"lineDigits",void 0),__decorate([property({type:Boolean,reflect:!0})],CodeMirrorElement.prototype,"autoheight",void 0),__decorate([property({type:Boolean})],CodeMirrorElement.prototype,"nolazyload",void 0),__decorate([property({type:Boolean})],CodeMirrorElement.prototype,"readonly",void 0),__decorate([property({type:Boolean,reflect:!0})],CodeMirrorElement.prototype,"fullscreen",void 0),__decorate([property({type:String})],CodeMirrorElement.prototype,"label",void 0),__decorate([property({type:String})],CodeMirrorElement.prototype,"placeholder",void 0),__decorate([property({type:String})],CodeMirrorElement.prototype,"panel",void 0),__decorate([state()],CodeMirrorElement.prototype,"editorTheme",void 0),__decorate([state()],CodeMirrorElement.prototype,"editorView",void 0),CodeMirrorElement=__decorate([customElement("typo3-t3editor-codemirror")],CodeMirrorElement);export{CodeMirrorElement};

0 comments on commit 6fe3cd8

Please sign in to comment.