Skip to content

Commit

Permalink
[BUGFIX] Use correct visitor in FE condition matching
Browse files Browse the repository at this point in the history
Patch for issue #101364 came with a bug using a wrong
visitor. This leads to potentially broken nested
condition matching calculation and cache files being
written too often.

Resolves: #102531
Related: #101364
Related: #97816
Releases: main, 12.4
Change-Id: Ica84e17da9ddf4671d0f1197248eb5b396d7e8b7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81910
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
  • Loading branch information
lolli42 committed Nov 27, 2023
1 parent 5a73c64 commit 7256ea0
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -1310,7 +1310,7 @@ public function getFromCache(ServerRequestInterface $request): ServerRequestInte
$includeTreeTraverserVisitors = [];
$conditionMatcherVisitor = GeneralUtility::makeInstance(IncludeTreeConditionMatcherVisitor::class);
$conditionMatcherVisitor->initializeExpressionMatcherWithVariables($expressionMatcherVariables);
$includeTreeTraverserVisitors[] = $constantAstBuilderVisitor;
$includeTreeTraverserVisitors[] = $conditionMatcherVisitor;
$constantConditionIncludeListAccumulatorVisitor = new IncludeTreeConditionIncludeListAccumulatorVisitor();
$includeTreeTraverserVisitors[] = $constantConditionIncludeListAccumulatorVisitor;
$includeTreeTraverser->traverse($constantIncludeTree, $includeTreeTraverserVisitors);
Expand Down

0 comments on commit 7256ea0

Please sign in to comment.