Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUGFIX] Handle localizeReferencesAtParentLocalization for group/db
TCA config property 'localizeReferencesAtParentLocalization' for database relations is only handled with type=select having a 'foreign_table' defined. With the similar type=group, this is only handled if 'foreign_table' is set, which is odd since group is based on 'allowed' over 'foreign_table'. The change adapts DataHandler to consider 'allowed' with type=group tables and checks whether at least one of them is localizable. This solves an @todo from #94570 in the group DataHandling tests. The test set is completed by adding a similar set for type=select. Resolves: #41713 Related: #94570 Releases: master Change-Id: I33df58fd4c9bdf31e27f64532c371c74b3f52627 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72102 Tested-by: core-ci <typo3@b13.com> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Benni Mack <benni@typo3.org>
- Loading branch information
1 parent
4709cc5
commit 7b6502f
Showing
13 changed files
with
276 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
...elect/Modify/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
"pages",,,,,,,,,,,,, | ||
,"uid","pid","sorting","deleted","t3_origuid","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","title",,, | ||
,1,0,256,0,0,0,0,0,0,"FunctionalTest",,, | ||
,88,1,256,0,0,0,0,0,0,"DataHandlerTest",,, | ||
,89,88,256,0,0,0,0,0,0,"Relations",,, | ||
,90,88,512,0,0,0,0,0,0,"Target",,, | ||
"sys_language",,,,,,,,,,,,, | ||
,"uid","pid","hidden","title","flag",,,,,,,, | ||
,1,0,0,"Dansk","dk",,,,,,,, | ||
,2,0,0,"Deutsch","de",,,,,,,, | ||
"tt_content",,,,,,,,,,,,, | ||
,"uid","pid","sorting","deleted","sys_language_uid","l18n_parent","t3_origuid","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","header","tx_testdatahandler_select" | ||
,297,89,256,0,0,0,0,0,0,0,0,"Regular Element #1","1,2" | ||
,298,89,512,0,0,0,0,0,0,0,0,"Regular Element #2","2,3" | ||
,299,89,768,0,1,298,298,0,0,0,0,"[Translate to Dansk:] Regular Element #2","4,5" | ||
"tx_testdatahandler_element",,,,,,,,,,,,, | ||
,"uid","pid","sorting","deleted","sys_language_uid","l10n_parent","t3_origuid","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","title", | ||
,1,89,256,0,0,0,0,0,0,0,0,"Element #1", | ||
,2,89,512,0,0,0,0,0,0,0,0,"Element #2", | ||
,3,89,768,0,0,0,0,0,0,0,0,"Element #3", | ||
,4,89,640,0,1,2,2,0,0,0,0,"[Translate to Dansk:] Element #2", | ||
,5,89,704,0,1,3,3,0,0,0,0,"[Translate to Dansk:] Element #3", | ||
"sys_refindex",,,,,,,,,,,,, | ||
,"hash","tablename","recuid","field","flexpointer","softref_key","softref_id","sorting","workspace","ref_table","ref_uid","ref_string", | ||
,"d7065184b2d510f3fada875169bc8c57","tt_content",297,"tx_testdatahandler_select",,,,0,0,"tx_testdatahandler_element",1,, | ||
,"d333521843e8774369e112581bd4643b","tt_content",297,"tx_testdatahandler_select",,,,1,0,"tx_testdatahandler_element",2,, | ||
,"fb9a4c46d91b175ee7503de71523c849","tt_content",298,"tx_testdatahandler_select",,,,0,0,"tx_testdatahandler_element",2,, | ||
,"f54bf3a4ddc51685c0586b31015312cb","tt_content",298,"tx_testdatahandler_select",,,,1,0,"tx_testdatahandler_element",3,, | ||
,"6dc66af7d395e5be3c87fc4e13c0455c","tt_content",299,"l18n_parent",,,,0,0,"tt_content",298,, | ||
,"a5a8bb1991a2c199cbe80e3e37844190","tx_testdatahandler_element",4,"l10n_parent",,,,0,0,"tx_irretutorial_1nff_hotel",2,, | ||
,"b76b4fe0aa225d718110c5d667c1d8b1","tt_content",299,"tx_testdatahandler_select",,,,0,0,"tx_testdatahandler_element",4,, | ||
,"d6055b07069ed11ff1463f05f096bf6a","tt_content",299,"tx_testdatahandler_select",,,,1,0,"tx_testdatahandler_element",5,, | ||
,"f32f8b540bfad29e0cc31794bb04c948","tx_testdatahandler_element",5,"l10n_parent",,,,0,0,"tx_irretutorial_1nff_hotel",3,, |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
...lect/Discard/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
"pages",,,,,,,,,,,,,,,,, | ||
,"uid","pid","sorting","deleted","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","title",,,,,,,, | ||
,1,0,256,0,0,0,0,0,"FunctionalTest",,,,,,,, | ||
,88,1,256,0,0,0,0,0,"DataHandlerTest",,,,,,,, | ||
,89,88,256,0,0,0,0,0,"Relations",,,,,,,, | ||
,90,88,512,0,0,0,0,0,"Target",,,,,,,, | ||
"sys_workspace",,,,,,,,,,,,,,,,, | ||
,"uid","pid","deleted","title","adminusers","members","db_mountpoints","file_mountpoints","freeze","live_edit","publish_access","custom_stages","stagechg_notification","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_defaults","publish_allow_notificaton_settings" | ||
,1,0,0,"Workspace #1",,,,,0,0,0,0,0,0,0,0,0 | ||
,2,0,0,"Workspace #2",,,,,0,0,0,0,0,0,0,0,0 | ||
"sys_workspace_stage",,,,,,,,,,,,,,,,, | ||
,"uid","pid","tstamp","deleted","sorting","title","responsible_persons","default_mailcomment","parentid","parenttable","notification_defaults","allow_notificaton_settings",,,,, | ||
,1,0,1290048921,0,1,"Stage 1","be_users_3",,1,"sys_workspace",0,0,,,,, | ||
"sys_language",,,,,,,,,,,,,,,,, | ||
,"uid","pid","hidden","title","flag",,,,,,,,,,,, | ||
,1,0,0,"Dansk","dk",,,,,,,,,,,, | ||
,2,0,0,"Deutsch","de",,,,,,,,,,,, | ||
"tt_content",,,,,,,,,,,,,,,,, | ||
,"uid","pid","sorting","deleted","sys_language_uid","l18n_parent","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","header","tx_testdatahandler_select",,,,, | ||
,297,89,256,0,0,0,0,0,0,0,"Regular Element #1","1,2",,,,, | ||
,298,89,512,0,0,0,0,0,0,0,"Regular Element #2","2,3",,,,, | ||
"tx_testdatahandler_element",,,,,,,,,,,,,,,,, | ||
,"uid","pid","sorting","deleted","sys_language_uid","l10n_parent","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","title","l10n_diffsource",,,,, | ||
,1,89,256,0,0,0,0,0,0,0,"Element #1",,,,,, | ||
,2,89,512,0,0,0,0,0,0,0,"Element #2",,,,,, | ||
,3,89,768,0,0,0,0,0,0,0,"Element #3",,,,,, | ||
# @todo: Note these two are *not* discarded when parent is discarded. Probably not intended since they are now orphan?! | ||
,4,89,640,0,1,2,1,1,0,0,"[Translate to Dansk:] Element #2",,,,,, | ||
,5,89,704,0,1,3,1,1,0,0,"[Translate to Dansk:] Element #3",,,,,, | ||
"sys_refindex",,,,,,,,,,,,,,,,, | ||
,"hash","tablename","recuid","field","flexpointer","softref_key","softref_id","sorting","workspace","ref_table","ref_uid","ref_string",,,,, | ||
,"d7065184b2d510f3fada875169bc8c57","tt_content",297,"tx_testdatahandler_select",,,,0,0,"tx_testdatahandler_element",1,,,,,, | ||
,"d333521843e8774369e112581bd4643b","tt_content",297,"tx_testdatahandler_select",,,,1,0,"tx_testdatahandler_element",2,,,,,, | ||
,"fb9a4c46d91b175ee7503de71523c849","tt_content",298,"tx_testdatahandler_select",,,,0,0,"tx_testdatahandler_element",2,,,,,, | ||
,"f54bf3a4ddc51685c0586b31015312cb","tt_content",298,"tx_testdatahandler_select",,,,1,0,"tx_testdatahandler_element",3,,,,,, | ||
,"25426f92d44dd2ccf416108462b446e3","sys_workspace",1,"custom_stages",,,,0,0,"sys_workspace_stage",1,,,,,, | ||
,"01a3ce8c4e3b2bb1aa439dc29081f996","sys_workspace_stage",1,"responsible_persons",,,,0,0,"be_users",3,,,,,, | ||
,"1ebdaf9cf728f19cd80c563e4c63a22e","tx_testdatahandler_element",4,"l10n_parent",,,,0,1,"tx_irretutorial_1nff_hotel",2,,,,,, | ||
,"4ff10724a18d4ed5323ad19158f4e807","tx_testdatahandler_element",5,"l10n_parent",,,,0,1,"tx_irretutorial_1nff_hotel",3,,,,,, |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
...elect/Modify/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
"pages",,,,,,,,,,,,,,,,, | ||
,"uid","pid","sorting","deleted","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","title",,,,,,,, | ||
,1,0,256,0,0,0,0,0,"FunctionalTest",,,,,,,, | ||
,88,1,256,0,0,0,0,0,"DataHandlerTest",,,,,,,, | ||
,89,88,256,0,0,0,0,0,"Relations",,,,,,,, | ||
,90,88,512,0,0,0,0,0,"Target",,,,,,,, | ||
"sys_workspace",,,,,,,,,,,,,,,,, | ||
,"uid","pid","deleted","title","adminusers","members","db_mountpoints","file_mountpoints","freeze","live_edit","publish_access","custom_stages","stagechg_notification","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_defaults","publish_allow_notificaton_settings" | ||
,1,0,0,"Workspace #1",,,,,0,0,0,0,0,0,0,0,0 | ||
,2,0,0,"Workspace #2",,,,,0,0,0,0,0,0,0,0,0 | ||
"sys_workspace_stage",,,,,,,,,,,,,,,,, | ||
,"uid","pid","tstamp","deleted","sorting","title","responsible_persons","default_mailcomment","parentid","parenttable","notification_defaults","allow_notificaton_settings",,,,, | ||
,1,0,1290048921,0,1,"Stage 1","be_users_3",,1,"sys_workspace",0,0,,,,, | ||
"sys_language",,,,,,,,,,,,,,,,, | ||
,"uid","pid","hidden","title","flag",,,,,,,,,,,, | ||
,1,0,0,"Dansk","dk",,,,,,,,,,,, | ||
,2,0,0,"Deutsch","de",,,,,,,,,,,, | ||
"tt_content",,,,,,,,,,,,,,,,, | ||
,"uid","pid","sorting","deleted","sys_language_uid","l18n_parent","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","header","tx_testdatahandler_select",,,,, | ||
,297,89,256,0,0,0,0,0,0,0,"Regular Element #1","1,2",,,,, | ||
,298,89,512,0,0,0,0,0,0,0,"Regular Element #2","2,3",,,,, | ||
,299,89,768,0,1,298,1,1,0,0,"[Translate to Dansk:] Regular Element #2","4,5",,,,, | ||
"tx_testdatahandler_element",,,,,,,,,,,,,,,,, | ||
,"uid","pid","sorting","deleted","sys_language_uid","l10n_parent","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","title","l10n_diffsource",,,,, | ||
,1,89,256,0,0,0,0,0,0,0,"Element #1",,,,,, | ||
,2,89,512,0,0,0,0,0,0,0,"Element #2",,,,,, | ||
,3,89,768,0,0,0,0,0,0,0,"Element #3",,,,,, | ||
,4,89,640,0,1,2,1,1,0,0,"[Translate to Dansk:] Element #2",,,,,, | ||
,5,89,704,0,1,3,1,1,0,0,"[Translate to Dansk:] Element #3",,,,,, | ||
"sys_refindex",,,,,,,,,,,,,,,,, | ||
,"hash","tablename","recuid","field","flexpointer","softref_key","softref_id","sorting","workspace","ref_table","ref_uid","ref_string",,,,, | ||
,"d7065184b2d510f3fada875169bc8c57","tt_content",297,"tx_testdatahandler_select",,,,0,0,"tx_testdatahandler_element",1,,,,,, | ||
,"d333521843e8774369e112581bd4643b","tt_content",297,"tx_testdatahandler_select",,,,1,0,"tx_testdatahandler_element",2,,,,,, | ||
,"fb9a4c46d91b175ee7503de71523c849","tt_content",298,"tx_testdatahandler_select",,,,0,0,"tx_testdatahandler_element",2,,,,,, | ||
,"f54bf3a4ddc51685c0586b31015312cb","tt_content",298,"tx_testdatahandler_select",,,,1,0,"tx_testdatahandler_element",3,,,,,, | ||
,"25426f92d44dd2ccf416108462b446e3","sys_workspace",1,"custom_stages",,,,0,0,"sys_workspace_stage",1,,,,,, | ||
,"01a3ce8c4e3b2bb1aa439dc29081f996","sys_workspace_stage",1,"responsible_persons",,,,0,0,"be_users",3,,,,,, | ||
,"1ebdaf9cf728f19cd80c563e4c63a22e","tx_testdatahandler_element",4,"l10n_parent",,,,0,1,"tx_irretutorial_1nff_hotel",2,,,,,, | ||
,"4ff10724a18d4ed5323ad19158f4e807","tx_testdatahandler_element",5,"l10n_parent",,,,0,1,"tx_irretutorial_1nff_hotel",3,,,,,, | ||
,"e4afda9b67d6ad42e03f5c797250235d","tt_content",299,"l18n_parent",,,,0,1,"tt_content",298,,,,,, | ||
,"de7643278f82017bce926bf4565c4cb9","tt_content",299,"tx_testdatahandler_select",,,,0,1,"tx_testdatahandler_element",4,,,,,, | ||
,"af5b779dd2258037770a0febe6d0054f","tt_content",299,"tx_testdatahandler_select",,,,1,1,"tx_testdatahandler_element",5,,,,,, |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.