Skip to content

Commit

Permalink
[BUGFIX] Do not swallow pointerdown event in finisher configuration
Browse files Browse the repository at this point in the history
With #98604, jQuery UI was replaced with SortableJS. It turns out that
filtered element, where dragging should be disabled, also calls
`preventDefault()` by default, leading to the issue that text fields
cannot get focused anymore.

As documented by SortableJS, `preventOnFilter` is now set to `false` to
allow editing text fields again whilst disabling dragging their parent
container.

Resolves: #99736
Related: #98604
Releases: main
Change-Id: I047cbe19a472e611cc5febaf29bb37f2ee1b7dc2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77882
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
  • Loading branch information
andreaskienast authored and o-ba committed Feb 16, 2023
1 parent 9f06cd5 commit 7b7cca1
Showing 1 changed file with 1 addition and 0 deletions.
Expand Up @@ -507,6 +507,7 @@ function factory($, Helper, Icons, Notification, Modal, MessageUtility) {
new Sortable(sortableDomElement.get(0), {
draggable: getHelper().getDomElementClassName('collectionElement', true),
filter: 'input,textarea,select',
preventOnFilter: false,
animation: 200,
fallbackTolerance: 200,
swapThreshold: 0.6,
Expand Down

0 comments on commit 7b7cca1

Please sign in to comment.