Skip to content

Commit

Permalink
[TASK] Make MethodArgumentDroppedMatcherTest notice free
Browse files Browse the repository at this point in the history
Resolves: #84314
Releases: master
Change-Id: Ic8cba1972407b51d7deedb40bc4161dc19ab1601
Reviewed-on: https://review.typo3.org/56187
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
  • Loading branch information
janhelke authored and lolli42 committed Mar 15, 2018
1 parent 129428c commit 8fa9956
Showing 1 changed file with 9 additions and 7 deletions.
Expand Up @@ -26,11 +26,6 @@
*/
class MethodArgumentDroppedMatcherTest extends UnitTestCase
{
/**
* Subject is not notice free, disable E_NOTICES
*/
protected static $suppressNotices = true;

/**
* @test
*/
Expand Down Expand Up @@ -67,7 +62,7 @@ public function hitsFromFixtureAreFound()
/**
* @return array
*/
public function matchesReturnsExpectedRestFilesDataProvider()
public function matchesReturnsExpectedRestFilesDataProvider(): array
{
return [
'two rest candidates with same number of arguments' => [
Expand Down Expand Up @@ -231,6 +226,9 @@ public function matchesReturnsExpectedRestFilesDataProvider()
/**
* @test
* @dataProvider matchesReturnsExpectedRestFilesDataProvider
* @param array $configuration
* @param string $phpCode
* @param array $expected
*/
public function matchesReturnsExpectedRestFiles(array $configuration, string $phpCode, array $expected)
{
Expand All @@ -244,6 +242,10 @@ public function matchesReturnsExpectedRestFiles(array $configuration, string $ph
$traverser->traverse($statements);

$result = $subject->getMatches();
$this->assertEquals($expected[0]['restFiles'], $result[0]['restFiles']);
if (isset($expected[0], $result[0])) {
$this->assertEquals($expected[0]['restFiles'], $result[0]['restFiles']);
} else {
$this->assertEquals($expected, $result);
}
}
}

0 comments on commit 8fa9956

Please sign in to comment.