[TASK] Make LinkServiceTest notice free

Resolves: #84328 Releases: master Change-Id: I2e8ae22db7c3e9853d6ae59d6c42f960001d5e74 Reviewed-on: https://review.typo3.org/56207 Tested-by: TYPO3com <no-reply@typo3.com> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
TYPO3 · Mar 16, 2018 · 90adc03 · 90adc03
1 parent 1069381
commit 90adc03
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/typo3/sysext/core/Classes/LinkHandling/LinkService.php b/typo3/sysext/core/Classes/LinkHandling/LinkService.php
@@ -50,7 +50,7 @@ public function __construct()
     {
         if (!empty($GLOBALS['TYPO3_CONF_VARS']['SYS']['linkHandler'])) {
             foreach ($GLOBALS['TYPO3_CONF_VARS']['SYS']['linkHandler'] as $type => $handler) {
-                if (!is_object($this->handlers[$type])) {
+                if (!isset($this->handlers[$type]) || !is_object($this->handlers[$type])) {
                     $this->handlers[$type] = GeneralUtility::makeInstance($handler);
                 }
             }

diff --git a/typo3/sysext/core/Tests/Unit/LinkHandling/LinkServiceTest.php b/typo3/sysext/core/Tests/Unit/LinkHandling/LinkServiceTest.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types = 1);
 namespace TYPO3\CMS\Core\Tests\Unit\LinkHandling;
 
 /*
@@ -19,11 +20,6 @@
 
 class LinkServiceTest extends UnitTestCase
 {
-    /**
-     * Subject is not notice free, disable E_NOTICES
-     */
-    protected static $suppressNotices = true;
-
     /**
      * Data to resolve strings to arrays and vice versa, external, mail, page
      *