Skip to content

Commit

Permalink
[BUGFIX] Restore FileInterface::setContents() TODO comments
Browse files Browse the repository at this point in the history
Resolves: #103202
Releases: main, 12.4
Related: #40096
Change-Id: If64a5d16da9d500180d070b8d5f6a7fd96609010
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83135
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Garvin Hicking <gh@faktor-e.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Reviewed-by: Garvin Hicking <gh@faktor-e.de>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
  • Loading branch information
mbrodala authored and andreaskienast committed Feb 26, 2024
1 parent 26389ad commit 9867da2
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions typo3/sysext/core/Classes/Resource/FileInterface.php
Expand Up @@ -96,8 +96,12 @@ public function getContents(): string;
/**
* Replace the current file contents with the given string.
*
* @TODO : Consider to remove this function from the interface, as its
* @TODO : At the same time, it could be considered whether to make the whole
* @todo: Consider to remove this function from the interface, as its
* implementation in FileInUse could cause unforseen side-effects by setting
* contents on the original file instead of just on the Usage of the file.
* @todo: At the same time, it could be considered whether to make the whole
* interface a read-only FileInterface, so that all file management and
* modification functions are removed...
* @return $this
*/
public function setContents(string $contents): self;
Expand Down

0 comments on commit 9867da2

Please sign in to comment.