[TASK] Make TextfieldViewHelperTest notice free

Releases: master Resolves: #84365 Change-Id: I09df5639ba60d7532dd5b8d7dddb1298086fe010 Reviewed-on: https://review.typo3.org/56242 Tested-by: TYPO3com <no-reply@typo3.com> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
TYPO3 · Mar 16, 2018 · a987175 · a987175
1 parent 1264d81
commit a987175
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php b/typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php
@@ -118,17 +118,17 @@ protected function getNameWithoutPrefix()
                 'formObjectName'
             );
             if (!empty($formObjectName)) {
-                $propertySegments = explode('.', $this->arguments['property']);
+                $propertySegments = explode('.', $this->arguments['property'] ?? '');
                 $propertyPath = '';
                 foreach ($propertySegments as $segment) {
                     $propertyPath .= '[' . $segment . ']';
                 }
                 $name = $formObjectName . $propertyPath;
             } else {
-                $name = $this->arguments['property'];
+                $name = $this->arguments['property'] ?? '';
             }
         } else {
-            $name = $this->arguments['name'];
+            $name = $this->arguments['name'] ?? '';
         }
         if ($this->hasArgument('value') && is_object($this->arguments['value'])) {
             // @todo Use  $this->persistenceManager->isNewObject() once it is implemented

diff --git a/typo3/sysext/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php b/typo3/sysext/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php
@@ -65,8 +65,8 @@ public function initializeArguments()
      */
     public function render()
     {
-        $required = $this->arguments['required'];
-        $type = $this->arguments['type'];
+        $required = $this->arguments['required'] ?? false;
+        $type = $this->arguments['type'] ?? null;
 
         $name = $this->getName();
         $this->registerFieldNameForFormTokenGeneration($name);

diff --git a/typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/TextfieldViewHelperTest.php b/typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/TextfieldViewHelperTest.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 namespace TYPO3\CMS\Fluid\Tests\Unit\ViewHelpers\Form;
 
 /*
@@ -23,11 +24,6 @@
  */
 class TextfieldViewHelperTest extends ViewHelperBaseTestcase
 {
-    /**
-     * Subject is not notice free, disable E_NOTICES
-     */
-    protected static $suppressNotices = true;
-
     /**
      * @var TextfieldViewHelper
      */