Skip to content

Commit

Permalink
[!!!][TASK] Clean up module icons
Browse files Browse the repository at this point in the history
With #95888 icon identifiers provided by TYPO3.Icons
are used for module icons, where they were not
already in place. The previously referenced icons
are now removed for TYPO3 v12.0.

Resolves: #96094
Related: #95888
Releases: master
Change-Id: I6d33538c2f04770a23f634b307b42e0712e36c7b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72316
Tested-by: core-ci <typo3@b13.com>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Benni Mack <benni@typo3.org>
  • Loading branch information
brotkrueml authored and bmack committed Nov 26, 2021
1 parent 09e4735 commit b737471
Show file tree
Hide file tree
Showing 27 changed files with 61 additions and 125 deletions.
100 changes: 0 additions & 100 deletions Build/Gruntfile.js
Expand Up @@ -254,74 +254,10 @@ module.exports = function (grunt) {
},
module_icons: {
files: [
{
dest: '<%= paths.sysext %>backend/Resources/Public/Icons/module-about.svg',
src: '<%= paths.t3icons %>svgs/module/module-about.svg'
},
{
dest: '<%= paths.sysext %>adminpanel/Resources/Public/Icons/module-adminpanel.svg',
src: '<%= paths.t3icons %>svgs/module/module-adminpanel.svg'
},
{
dest: '<%= paths.sysext %>belog/Resources/Public/Icons/module-belog.svg',
src: '<%= paths.t3icons %>svgs/module/module-belog.svg'
},
{
dest: '<%= paths.sysext %>beuser/Resources/Public/Icons/module-beuser.svg',
src: '<%= paths.t3icons %>svgs/module/module-beuser.svg'
},
{
dest: '<%= paths.sysext %>backend/Resources/Public/Icons/module-cshmanual.svg',
src: '<%= paths.t3icons %>svgs/module/module-cshmanual.svg'
},
{
dest: '<%= paths.sysext %>backend/Resources/Public/Icons/module-page.svg',
src: '<%= paths.t3icons %>svgs/module/module-page.svg'
},
{
dest: '<%= paths.sysext %>backend/Resources/Public/Icons/module-sites.svg',
src: '<%= paths.t3icons %>svgs/module/module-sites.svg'
},
{
dest: '<%= paths.sysext %>backend/Resources/Public/Icons/module-templates.svg',
src: '<%= paths.t3icons %>svgs/module/module-templates.svg'
},
{
dest: '<%= paths.sysext %>backend/Resources/Public/Icons/module-urls.svg',
src: '<%= paths.t3icons %>svgs/module/module-urls.svg'
},
{
dest: '<%= paths.sysext %>backend/Resources/Public/Icons/module-contentelements.svg',
src: '<%= paths.t3icons %>svgs/module/module-contentelements.svg'
},
{
dest: '<%= paths.sysext %>lowlevel/Resources/Public/Icons/module-config.svg',
src: '<%= paths.t3icons %>svgs/module/module-config.svg'
},
{
dest: '<%= paths.sysext %>lowlevel/Resources/Public/Icons/module-dbint.svg',
src: '<%= paths.t3icons %>svgs/module/module-dbint.svg'
},
{
dest: '<%= paths.sysext %>extensionmanager/Resources/Public/Icons/module-extensionmanager.svg',
src: '<%= paths.t3icons %>svgs/module/module-extensionmanager.svg'
},
{
dest: '<%= paths.sysext %>filelist/Resources/Public/Icons/module-filelist.svg',
src: '<%= paths.t3icons %>svgs/module/module-filelist.svg'
},
{
dest: '<%= paths.sysext %>form/Resources/Public/Icons/module-form.svg',
src: '<%= paths.t3icons %>svgs/module/module-form.svg'
},
{
dest: '<%= paths.sysext %>indexed_search/Resources/Public/Icons/module-indexed_search.svg',
src: '<%= paths.t3icons %>svgs/module/module-indexed_search.svg'
},
{
dest: '<%= paths.sysext %>info/Resources/Public/Icons/module-info.svg',
src: '<%= paths.t3icons %>svgs/module/module-info.svg'
},
{
dest: '<%= paths.sysext %>install/Resources/Public/Icons/module-install.svg',
src: '<%= paths.t3icons %>svgs/module/module-install.svg'
Expand All @@ -341,42 +277,6 @@ module.exports = function (grunt) {
{
dest: '<%= paths.sysext %>install/Resources/Public/Icons/module-install-upgrade.svg',
src: '<%= paths.t3icons %>svgs/module/module-install-upgrade.svg'
},
{
dest: '<%= paths.sysext %>recordlist/Resources/Public/Icons/module-list.svg',
src: '<%= paths.t3icons %>svgs/module/module-list.svg'
},
{
dest: '<%= paths.sysext %>beuser/Resources/Public/Icons/module-permission.svg',
src: '<%= paths.t3icons %>svgs/module/module-permission.svg'
},
{
dest: '<%= paths.sysext %>recycler/Resources/Public/Icons/module-recycler.svg',
src: '<%= paths.t3icons %>svgs/module/module-recycler.svg'
},
{
dest: '<%= paths.sysext %>reports/Resources/Public/Icons/module-reports.svg',
src: '<%= paths.t3icons %>svgs/module/module-reports.svg'
},
{
dest: '<%= paths.sysext %>scheduler/Resources/Public/Icons/module-scheduler.svg',
src: '<%= paths.t3icons %>svgs/module/module-scheduler.svg'
},
{
dest: '<%= paths.sysext %>setup/Resources/Public/Icons/module-setup.svg',
src: '<%= paths.t3icons %>svgs/module/module-setup.svg'
},
{
dest: '<%= paths.sysext %>tstemplate/Resources/Public/Icons/module-tstemplate.svg',
src: '<%= paths.t3icons %>svgs/module/module-tstemplate.svg'
},
{
dest: '<%= paths.sysext %>viewpage/Resources/Public/Icons/module-viewpage.svg',
src: '<%= paths.t3icons %>svgs/module/module-viewpage.svg'
},
{
dest: '<%= paths.sysext %>workspaces/Resources/Public/Icons/module-workspaces.svg',
src: '<%= paths.t3icons %>svgs/module/module-workspaces.svg'
}
]
},
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion typo3/sysext/belog/Resources/Public/Icons/module-belog.svg

This file was deleted.

This file was deleted.

This file was deleted.

@@ -0,0 +1,61 @@
.. include:: ../../Includes.txt

=======================================
Breaking: #96094 - Module icons removed
=======================================

See :issue:`96094`

Description
===========

The following module icons are removed as they are not needed anymore
by TYPO3 itself. You can find the according icon identifier in parenthesis.

* EXT:backend/Resources/Public/Icons/module-about.svg (`module-about`)
* EXT:backend/Resources/Public/Icons/module-contentelements.svg (`module-contentelements`)
* EXT:backend/Resources/Public/Icons/module-cshmanual.svg (`module-cshmanual`)
* EXT:backend/Resources/Public/Icons/module-page.svg (`module-page`)
* EXT:backend/Resources/Public/Icons/module-sites.svg (`module-sites`)
* EXT:backend/Resources/Public/Icons/module-templates.svg (`module-templates`)
* EXT:backend/Resources/Public/Icons/module-urls.svg (`module-urls`)
* EXT:belog/Resources/Public/Icons/module-belog.svg (`module-belog`)
* EXT:beuser/Resources/Public/Icons/module-beuser.svg (`module-beuser`)
* EXT:beuser/Resources/Public/Icons/module-permission.svg (`module-permission`)
* EXT:extensionmanager/Resources/Public/Icons/module-extensionmanager.svg (`module-extensionmanager`)
* EXT:filelist/Resources/Public/Icons/module-filelist.svg (`module-filelist`)
* EXT:form/Resources/Public/Icons/module-form.svg (`module-form`)
* EXT:indexed_search/Resources/Public/Icons/module-indexed_search.svg (`module-indexed_search`)
* EXT:info/Resources/Public/Icons/module-info.svg (`module-info`)
* EXT:lowlevel/Resources/Public/Icons/module-config.svg (`module-config`)
* EXT:lowlevel/Resources/Public/Icons/module-dbint.svg (`module-dbint`)
* EXT:recordlist/Resources/Public/Icons/module-list.svg (`module-list`)
* EXT:recycler/Resources/Public/Icons/module-recycler.svg (`module-recycler`)
* EXT:reports/Resources/Public/Icons/module-reports.svg (`module-reports`)
* EXT:scheduler/Resources/Public/Icons/module-scheduler.svg (`module-scheduler`)
* EXT:setup/Resources/Public/Icons/module-setup.svg (`module-setup`)
* EXT:tstemplate/Resources/Public/Icons/module-tstemplate.svg (`module-tstemplate`)
* EXT:viewpage/Resources/Public/Icons/module-viewpage.svg (`module-viewpage`)
* EXT:workspaces/Resources/Public/Icons/module-workspaces.svg (`module-workspaces`)

Impact
======

The mentioned icons are removed, any usage by path will result in a broken
image.

Affected Installations
======================

Third-party TYPO3 extensions using these icons.

Migration
=========

Use the already available icon identifiers from `TYPO3.Icons <https://typo3.github.io/TYPO3.Icons/>`_.
The module icons are all registered automatically by the IconRegistry.
In Fluid you can render them by calling :html:`<core:icon identifier="module-icon">`.
In case you need the SVG file directly, download it from the above-mentioned
icon repository page.

.. index:: Backend, NotScanned

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion typo3/sysext/form/Resources/Public/Icons/module-form.svg

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion typo3/sysext/info/Resources/Public/Icons/module-info.svg

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit b737471

Please sign in to comment.