Skip to content

Commit

Permalink
[BUGFIX] Use unique keys for includeJSLibs and addJsFooterLibrary
Browse files Browse the repository at this point in the history
As both TS configurations use its key the latter must use a prefix
to avoid an instant override of rendered JS file.

Resolves: #85353
Releases: master, 8.7
Change-Id: Icb685eb0ed278aafead274c1fcf86436c9e6865d
Reviewed-on: https://review.typo3.org/57360
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
  • Loading branch information
georgringer authored and neufeind committed Jun 24, 2018
1 parent c2d1150 commit c78e9b4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions typo3/sysext/core/Classes/Page/PageRenderer.php
Expand Up @@ -1081,6 +1081,7 @@ public function addJsFooterLibrary($name, $file, $type = 'text/javascript', $com
if (!$type) {
$type = 'text/javascript';
}
$name .= '_jsFooterLibrary';
if (!in_array(strtolower($name), $this->jsLibs)) {
$this->jsLibs[strtolower($name)] = [
'file' => $file,
Expand Down

0 comments on commit c78e9b4

Please sign in to comment.