Skip to content

Commit

Permalink
[TASK] Move new SEO fields to separate system extension
Browse files Browse the repository at this point in the history
Move the new SEO fields to EXT:seo and prepare the extension for some
basic SEO features.

Resolves: #85194
Releases: master
Change-Id: I6ec087928080e217ce1824b2e9ad5cf0ca0606c8
Reviewed-on: https://review.typo3.org/57148
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
  • Loading branch information
Richard Haeser authored and susannemoog committed Jun 9, 2018
1 parent 7900d89 commit c888f73
Show file tree
Hide file tree
Showing 28 changed files with 856 additions and 376 deletions.
2 changes: 2 additions & 0 deletions composer.json
Expand Up @@ -138,6 +138,7 @@
"typo3/cms-rte-ckeditor": "self.version",
"typo3/cms-saltedpasswords": "self.version",
"typo3/cms-scheduler": "self.version",
"typo3/cms-seo": "self.version",
"typo3/cms-setup": "self.version",
"typo3/cms-sys-action": "self.version",
"typo3/cms-sys-note": "self.version",
Expand Down Expand Up @@ -181,6 +182,7 @@
"TYPO3\\CMS\\Rsaauth\\": "typo3/sysext/rsaauth/Classes/",
"TYPO3\\CMS\\RteCKEditor\\": "typo3/sysext/rte_ckeditor/Classes/",
"TYPO3\\CMS\\Saltedpasswords\\": "typo3/sysext/saltedpasswords/Classes/",
"TYPO3\\CMS\\Seo\\": "typo3/sysext/seo/Classes/",
"TYPO3\\CMS\\Scheduler\\": "typo3/sysext/scheduler/Classes/",
"TYPO3\\CMS\\Setup\\": "typo3/sysext/setup/Classes/",
"TYPO3\\CMS\\SysAction\\": "typo3/sysext/sys_action/Classes/",
Expand Down
2 changes: 1 addition & 1 deletion composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

164 changes: 1 addition & 163 deletions typo3/sysext/core/Configuration/TCA/pages.php
Expand Up @@ -880,147 +880,6 @@
'softref' => 'ext_fileref'
]
],
'seo_title' => [
'exclude' => true,
'l10n_mode' => 'prefixLangTitle',
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.seo_title',
'config' => [
'type' => 'input',
'size' => 40,
'max' => 255,
'eval' => 'trim'
]
],
'no_index' => [
'exclude' => true,
'l10n_mode' => 'exclude',
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.no_index',
'config' => [
'type' => 'check',
'renderType' => 'checkboxToggle',
'items' => [
[
'0' => '',
'1' => '',
'invertStateDisplay' => true
]
]
]
],
'no_follow' => [
'exclude' => true,
'l10n_mode' => 'exclude',
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.no_follow',
'config' => [
'type' => 'check',
'renderType' => 'checkboxToggle',
'items' => [
[
'0' => '',
'1' => '',
'invertStateDisplay' => true
]
]
]
],
'og_title' => [
'exclude' => true,
'l10n_mode' => 'prefixLangTitle',
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.og_title',
'config' => [
'type' => 'input',
'size' => 40,
'max' => 255,
'eval' => 'trim'
]
],
'og_description' => [
'exclude' => true,
'l10n_mode' => 'prefixLangTitle',
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.og_description',
'config' => [
'type' => 'text',
'cols' => 40,
'rows' => 3
]
],
'og_image' => [
'exclude' => true,
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.og_image',
'config' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::getFileFieldTCAConfig(
'og_image',
[
// Use the imageoverlayPalette instead of the basicoverlayPalette
'overrideChildTca' => [
'types' => [
'0' => [
'showitem' => '
--palette--;;imageoverlayPalette,
--palette--;;filePalette'
],
\TYPO3\CMS\Core\Resource\File::FILETYPE_IMAGE => [
'showitem' => '
--palette--;;imageoverlayPalette,
--palette--;;filePalette'
]
],
],
'behaviour' => [
'allowLanguageSynchronization' => true
]
],
$GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext']
)
],
'twitter_title' => [
'exclude' => true,
'l10n_mode' => 'prefixLangTitle',
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.twitter_title',
'config' => [
'type' => 'input',
'size' => 40,
'max' => 255,
'eval' => 'trim'
]
],
'twitter_description' => [
'exclude' => true,
'l10n_mode' => 'prefixLangTitle',
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.twitter_description',
'config' => [
'type' => 'text',
'cols' => 40,
'rows' => 3
]
],
'twitter_image' => [
'exclude' => true,
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.twitter_image',
'config' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::getFileFieldTCAConfig(
'twitter_image',
[
// Use the imageoverlayPalette instead of the basicoverlayPalette
'overrideChildTca' => [
'types' => [
'0' => [
'showitem' => '
--palette--;;imageoverlayPalette,
--palette--;;filePalette'
],
\TYPO3\CMS\Core\Resource\File::FILETYPE_IMAGE => [
'showitem' => '
--palette--;;imageoverlayPalette,
--palette--;;filePalette'
]
],
],
'behaviour' => [
'allowLanguageSynchronization' => true
]
],
$GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext']
)
],
],
'types' => [
// normal
Expand All @@ -1029,11 +888,6 @@
--div--;LLL:EXT:core/Resources/Private/Language/Form/locallang_tabs.xlf:general,
--palette--;;standard,
--palette--;;title,
--div--;LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.tabs.seo,
--palette--;;seo,
--palette--;;robots,
--palette--;;opengraph,
--palette--;;twittercards,
--div--;LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.tabs.metadata,
--palette--;;abstract,
--palette--;;metatags,
Expand Down Expand Up @@ -1266,7 +1120,7 @@
],
'metatags' => [
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.palettes.metatags',
'showitem' => 'keywords;LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.keywords_formlabel,',
'showitem' => 'keywords;LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.keywords_formlabel, --linebreak--, description;LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.description_formlabel',
],
'editorial' => [
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.palettes.editorial',
Expand Down Expand Up @@ -1316,21 +1170,5 @@
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.palettes.config',
'showitem' => 'tsconfig_includes;LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.tsconfig_includes, --linebreak--, TSconfig;LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.TSconfig_formlabel',
],
'seo' => [
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.palettes.seo',
'showitem' => 'seo_title;LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.seo_title, --linebreak--, description;LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.description_formlabel',
],
'robots' => [
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.palettes.robots',
'showitem' => 'no_index;LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.no_index_formlabel, no_follow;LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.no_follow_formlabel',
],
'opengraph' => [
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.palettes.opengraph',
'showitem' => 'og_title, --linebreak--, og_description, --linebreak--, og_image',
],
'twittercards' => [
'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.palettes.twittercards',
'showitem' => 'twitter_title, --linebreak--, twitter_description, --linebreak--, twitter_image',
],
]
];
Expand Up @@ -9,8 +9,9 @@ See :issue:`84798`
Description
===========

This feature adds SEO fields to Pages TCA. A new tab SEO now exists in the Page module which contains SEO related
metadata. Other non-SEO metadata is still on the Metadata tab.
A new system extension called SEO is introduced. This extension adds SEO fields to Pages TCA. When this extension is
installed, a new tab SEO appears in the Page module which contains SEO related metadata. Other non-SEO metadata is
still on the Metadata tab.


Impact
Expand All @@ -29,4 +30,4 @@ New fields added to Pages table:
- twitter_description
- twitter_image

.. index:: Backend, Database, TCA, ext:core
.. index:: Backend, Database, TCA, ext:seo
Expand Up @@ -9,14 +9,15 @@ See :issue:`85147`
Description
===========

The SEO meta tags that can be set in the page properties, are now rendered in frontend by default.
The SEO meta tags that can be set in the page properties, are now rendered in frontend by default if the system extension
SEO is installed.


Impact
======

No addition configuration is needed to render these meta tags. If you want to override the meta tags set by
the pageproperties, you can use the replace parameter in TypoScript or in the addProperty method of the specific
No additional configuration is needed to render these meta tags. If you want to override the meta tags set by
the page properties, you can use the replace parameter in TypoScript or in the addProperty method of the specific
MetaTagManager.

.. index:: Frontend, ext:core
.. index:: Frontend, ext:seo
Expand Up @@ -4,9 +4,9 @@
,88,1,256,0,0,0,0,0,0,0,0,0,"DataHandlerTest",0,,,
,89,88,256,0,0,0,0,0,0,0,0,0,"Relations",1,,,
,90,88,512,0,0,0,0,0,0,0,0,0,"Target",0,,,
,91,88,256,0,1,89,0,0,0,0,0,0,"[Translate to Dansk:] Relations",1,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""og_image"":""parent"",""twitter_image"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
,91,88,256,0,1,89,0,0,0,0,0,0,"[Translate to Dansk:] Relations",1,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
,92,90,256,0,0,0,89,0,0,0,0,0,"Relations",1,,,
,93,90,256,0,1,92,91,0,0,0,0,0,"[Translate to Dansk:] Relations",1,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""og_image"":""parent"",""twitter_image"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
,93,90,256,0,1,92,91,0,0,0,0,0,"[Translate to Dansk:] Relations",1,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
"tt_content",,,,,,,,,,,,,,,,,
,"uid","pid","sorting","deleted","sys_language_uid","l18n_parent","t3_origuid","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","t3ver_move_id","header","tx_irretutorial_1nff_hotels",,,
,297,89,256,0,0,0,0,0,0,0,0,0,"Regular Element #1",2,,,
Expand Down
Expand Up @@ -4,9 +4,9 @@
,88,1,256,0,0,0,0,0,0,0,0,0,"DataHandlerTest",0,,,
,89,88,256,0,0,0,0,0,0,0,0,0,"Relations",2,,,
,90,88,512,0,0,0,0,0,0,0,0,0,"Target",0,,,
,91,88,256,0,1,89,0,0,0,0,0,0,"[Translate to Dansk:] Relations",2,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""og_image"":""parent"",""twitter_image"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
,91,88,256,0,1,89,0,0,0,0,0,0,"[Translate to Dansk:] Relations",2,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
,92,90,256,0,0,0,89,0,0,0,0,0,"Relations",2,,,
,93,90,256,0,1,92,91,0,0,0,0,0,"[Translate to Dansk:] Relations",2,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""og_image"":""parent"",""twitter_image"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
,93,90,256,0,1,92,91,0,0,0,0,0,"[Translate to Dansk:] Relations",2,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
"tt_content",,,,,,,,,,,,,,,,,
,"uid","pid","sorting","deleted","sys_language_uid","l18n_parent","t3_origuid","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","t3ver_move_id","header","tx_irretutorial_1nff_hotels",,,
,297,89,256,0,0,0,0,0,0,0,0,0,"Regular Element #1",2,,,
Expand Down
Expand Up @@ -4,7 +4,7 @@
,88,1,256,0,0,0,0,0,0,0,0,0,"DataHandlerTest",0,,,
,89,88,256,0,0,0,0,0,0,0,0,0,"Relations",2,,,
,90,88,512,0,0,0,0,0,0,0,0,0,"Target",0,,,
,91,88,256,0,1,89,0,0,0,0,0,0,"[Translate to Dansk:] Relations",2,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""og_image"":""parent"",""twitter_image"":""parent""}",,
,91,88,256,0,1,89,0,0,0,0,0,0,"[Translate to Dansk:] Relations",2,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent""}",,
"tt_content",,,,,,,,,,,,,,,,,
,"uid","pid","sorting","deleted","sys_language_uid","l18n_parent","t3_origuid","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","t3ver_move_id","header","tx_irretutorial_1nff_hotels",,,
,297,89,256,0,0,0,0,0,0,0,0,0,"Regular Element #1",2,,,
Expand Down
Expand Up @@ -4,7 +4,7 @@
,88,1,256,0,0,0,0,0,0,0,0,0,"DataHandlerTest",0,,,
,89,88,256,0,0,0,0,0,0,0,0,0,"Relations",2,,,
,90,88,512,0,0,0,0,0,0,0,0,0,"Target",0,,,
,91,88,256,0,1,89,0,0,0,0,0,0,"[Translate to Dansk:] Relations",2,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""og_image"":""parent"",""twitter_image"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
,91,88,256,0,1,89,0,0,0,0,0,0,"[Translate to Dansk:] Relations",2,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
"tt_content",,,,,,,,,,,,,,,,,
,"uid","pid","sorting","deleted","sys_language_uid","l18n_parent","t3_origuid","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","t3ver_move_id","header","tx_irretutorial_1nff_hotels",,,
,297,89,256,0,0,0,0,0,0,0,0,0,"Regular Element #1",2,,,
Expand Down
Expand Up @@ -4,7 +4,7 @@
,88,1,256,0,0,0,0,0,0,0,0,0,"DataHandlerTest",0,,,
,89,88,256,0,0,0,0,0,0,0,0,0,"Relations",2,,,
,90,88,512,0,0,0,0,0,0,0,0,0,"Target",0,,,
,91,88,256,0,1,89,0,0,0,0,0,0,"[Translate to Dansk:] Relations",2,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""og_image"":""parent"",""twitter_image"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
,91,88,256,0,1,89,0,0,0,0,0,0,"[Translate to Dansk:] Relations",2,"{""starttime"":""parent"",""endtime"":""parent"",""url"":""parent"",""lastUpdated"":""parent"",""newUntil"":""parent"",""no_search"":""parent"",""shortcut"":""parent"",""shortcut_mode"":""parent"",""author"":""parent"",""author_email"":""parent"",""media"":""parent"",""tx_irretutorial_hotels"":""parent""}",,
"tt_content",,,,,,,,,,,,,,,,,
,"uid","pid","sorting","deleted","sys_language_uid","l18n_parent","t3_origuid","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","t3ver_move_id","header","tx_irretutorial_1nff_hotels",,,
,297,89,256,0,0,0,0,0,0,0,0,0,"Regular Element #1",2,,,
Expand Down

0 comments on commit c888f73

Please sign in to comment.