[TASK] Deprecate old syntax for IRRE localize synchronize in DataHandler

With TYPO3 v7.6 the internal DataHandler command to "inlineLocalizeSynchronize" was migrated to an array-based syntax, and TYPO3 Core uses this ever since. With TYPO3 v11 it is time to deprecate the old behavior. Resolves: #95317 Releases: master Change-Id: I325f54d3cf3ab318a7528a393bf0d848e8b5e3b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71184 Tested-by: core-ci <typo3@b13.com> Tested-by: Oliver Hader <oliver.hader@typo3.org> Tested-by: Wouter Wolters <typo3@wouterwolters.nl> Tested-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by: Oliver Hader <oliver.hader@typo3.org> Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
TYPO3 · Sep 22, 2021 · da0aadf · da0aadf
1 parent 18c362f
commit da0aadf
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 0 deletions.
diff --git a/typo3/sysext/core/Classes/DataHandling/DataHandler.php b/typo3/sysext/core/Classes/DataHandling/DataHandler.php
@@ -4609,6 +4609,8 @@ protected function inlineLocalizeSynchronize($table, $id, $command)
 
         // Backward-compatibility handling
         if (!is_array($command)) {
+            // @deprecated, will be removed in TYPO3 v12.0.
+            trigger_error('DataHandler command InlineLocalizeSynchronize needs to use an array as command input, which is available since TYPO3 v7.6. This fallback mechanism will be removed in TYPO3 v12.0.', E_USER_DEPRECATED);
             // <field>, (localize | synchronize | <uid>):
             $parts = GeneralUtility::trimExplode(',', $command);
             $command = [

diff --git a/...eprecation-95317-LegacySyntaxForIRRELocalizeSynchronizeCommandInDataHandler.rst b/...eprecation-95317-LegacySyntaxForIRRELocalizeSynchronizeCommandInDataHandler.rst
@@ -0,0 +1,45 @@
+.. include:: ../../Includes.txt
+
+========================================================================================
+Deprecation: #95317 - Legacy syntax for IRRE localize synchronize command in DataHandler
+========================================================================================
+
+See :issue:`95317`
+
+Description
+===========
+
+The DataHandler command "inlineLocalizeSynchronize" now
+triggers a warning if the incoming command payload is sent
+as comma-separated list rather than an array.
+
+The array allows to synchronize/localize multiple values at once,
+which is preferred since TYPO3 v7.6, and used in TYPO3 properly
+since then.
+
+
+Impact
+======
+
+Calling DataHandler `process_cmdmap` with an incoming
+command for "inlineLocalizeSynchronize" with a payload
+of comma-separated values will trigger a PHP deprecation warning.
+
+
+Affected Installations
+======================
+
+TYPO3 installations with custom code related to DataHandler
+and modifying the "inlineLocalizeSynchronize" command,
+which is highly unlikely. This only affects special
+handling of "inline" configuration fields.
+
+
+Migration
+=========
+
+See "Important-71126-AllowToDefineMultipleInlineLocalizeSynchronizeCommands.rst"
+for further information on how to migrate your incoming
+DataHandler command.
+
+.. index:: PHP-API, NotScanned, ext:core