Skip to content

Commit

Permalink
[BUGFIX] Pass defLangBinding to generateLanguageView
Browse files Browse the repository at this point in the history
In #90315 the PageLayoutView was refactored. Mainly
`getTable_tt_content` was spitted in smaller functions.

Therefore a new function `generateLanguageView` was
introduced but missed `defLangBinding` in the parameter
signature. The parameter is now registered and correctly
passed to the function.

Resolves: #90617
Relates: #90315
Releases: master, 10.4
Change-Id: Ic7d4817cfc1799f2f95aec628fabeba7240b511c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65983
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
  • Loading branch information
o-ba authored and georgringer committed Oct 5, 2020
1 parent 5fd6839 commit daf5fc3
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions typo3/sysext/backend/Classes/View/PageLayoutView.php
Expand Up @@ -673,7 +673,7 @@ public function getTable_tt_content($id)
// Notice that THIS presentation will override the value of $out!
// But it needs the code above to execute since $languageColumn is filled with content we need!
if ($this->tt_contentConfig['languageMode']) {
return $this->generateLanguageView($languageIds, $defaultLanguageElementsByColumn, $languageColumn);
return $this->generateLanguageView($languageIds, $defaultLanguageElementsByColumn, $languageColumn, $defLangBinding);
}
return $out;
}
Expand All @@ -683,10 +683,15 @@ public function getTable_tt_content($id)
* @param array $languageIds languages to render
* @param array $defaultLanguageElementsByColumn
* @param array $languageColumn
* @param array $defLangBinding
* @return string the compiled content
*/
protected function generateLanguageView(array $languageIds, array $defaultLanguageElementsByColumn, array $languageColumn): string
{
protected function generateLanguageView(
array $languageIds,
array $defaultLanguageElementsByColumn,
array $languageColumn,
array $defLangBinding
): string {
// Get language selector:
$languageSelector = $this->languageSelector($this->id);
// Reset out - we will make new content here:
Expand Down

0 comments on commit daf5fc3

Please sign in to comment.