[BUGFIX] Convert URLs to punycode

Resolves: #55155 Releases: master, 8.7 Change-Id: If7c099647a73d25f86ac38bdda67935deb4930e0 Reviewed-on: https://review.typo3.org/56051 Tested-by: TYPO3com <no-reply@typo3.com> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
TYPO3 · Mar 8, 2018 · f9d07db · f9d07db
1 parent 1f4cb28
commit f9d07db
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php b/typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php
@@ -16,6 +16,7 @@
 
 use GuzzleHttp\Cookie\CookieJar;
 use GuzzleHttp\Exception\TooManyRedirectsException;
+use Mso\IdnaConvert\IdnaConvert;
 use TYPO3\CMS\Core\Http\RequestFactory;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
@@ -65,15 +66,14 @@ public function checkLink($url, $softRefEntry, $reference)
             }
             return $this->urlReports[$url];
         }
-
         $options = [
             'cookies' => GeneralUtility::makeInstance(CookieJar::class),
             'allow_redirects' => ['strict' => true]
         ];
 
-        /** @var RequestFactory $requestFactory */
         $requestFactory = GeneralUtility::makeInstance(RequestFactory::class);
         try {
+            $url = $this->preprocessUrl($url);
             $response = $requestFactory->request($url, 'HEAD', $options);
             // HEAD was not allowed or threw an error, now trying GET
             if ($response->getStatusCode() >= 400) {
@@ -100,6 +100,7 @@ public function checkLink($url, $softRefEntry, $reference)
             $errorParams['errorType'] = 'network';
             $errorParams['message'] = $this->getErrorMessage($errorParams);
         } catch (\Exception $e) {
+            // Generic catch for anything else that may go wrong
             $isValidUrl = false;
             $errorParams['errorType'] = 'exception';
             $errorParams['message'] = $e->getMessage();
@@ -166,4 +167,15 @@ public function fetchType($value, $type, $key)
         }
         return $type;
     }
+
+    /**
+     * Convert given URL to punycode to handle domains with non-ASCII characters
+     *
+     * @param string $url
+     * @return string
+     */
+    protected function preprocessUrl(string $url): string
+    {
+        return (new IdnaConvert())->encode($url);
+    }
 }
diff --git a/typo3/sysext/linkvalidator/Resources/Private/Language/Module/locallang.xlf b/typo3/sysext/linkvalidator/Resources/Private/Language/Module/locallang.xlf
@@ -184,7 +184,7 @@
 				<source>Exception: %s</source>
 			</trans-unit>
 			<trans-unit id="list.report.networkexception">
-				<source>Network error</source>
+				<source>Network error / invalid domain</source>
 			</trans-unit>
 			<trans-unit id="list.msg.ok">
 				<source>Ok</source>