Skip to content

Commit

Permalink
[BUGFIX] Remove "overflow: hidden" from form-wizards-element
Browse files Browse the repository at this point in the history
In order to fix select fields overflowing into each other
when they have very long option titles, the CSS rule
"overflow: hidden" has been added. As it seems, this wasn't
even necessary as the rule "min-width: 120px" already does
the trick.

The CSS rule "overflow: hidden" is now removed, which
enables the accessibility box-shadows from bootstrap 5
again.

Resolves: #97565
Related: #94688
Releases: main, 11.5
Change-Id: Ifd8495430ecdc404fa1dbebe9633ef5f401a6af6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74470
Tested-by: core-ci <typo3@b13.com>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
  • Loading branch information
nhovratov committed May 6, 2022
1 parent d09bec9 commit ff8c957
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
4 changes: 0 additions & 4 deletions Build/Sources/Sass/typo3/_main_form.scss
Expand Up @@ -315,10 +315,6 @@ select {
grid-area: main;
min-width: 120px;

&:not(.form-wizards-element--overflow-visible) {
overflow: hidden;
}

.col-icon img,
.inline-icon img {
max-width: 2em;
Expand Down
Expand Up @@ -176,7 +176,7 @@ public function render()
$mainFieldHtml = [];
$mainFieldHtml[] = '<div class="form-control-wrap" style="max-width: ' . $width . 'px">';
$mainFieldHtml[] = '<div class="form-wizards-wrap">';
$mainFieldHtml[] = '<div class="form-wizards-element form-wizards-element--overflow-visible">';
$mainFieldHtml[] = '<div class="form-wizards-element">';
$mainFieldHtml[] = '<input type="text" ' . GeneralUtility::implodeAttributes($attributes, true) . ' />';
$mainFieldHtml[] = '<input type="hidden" name="' . $parameterArray['itemFormElName'] . '" value="' . htmlspecialchars($itemValue) . '" />';
$mainFieldHtml[] = '</div>';
Expand Down
2 changes: 1 addition & 1 deletion typo3/sysext/backend/Resources/Public/Css/backend.css

Large diffs are not rendered by default.

0 comments on commit ff8c957

Please sign in to comment.