Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also cache package download dir #15

Closed
Enter-tainer opened this issue Jan 11, 2024 · 1 comment · Fixed by #16
Closed

Also cache package download dir #15

Enter-tainer opened this issue Jan 11, 2024 · 1 comment · Fixed by #16

Comments

@Enter-tainer
Copy link

https://github.com/typst/packages?tab=readme-ov-file#downloads

packages are downloaded each time when action runs. It might be good if we cache them. This may speed up e2e time and avoid failure due to unstable network issues.

@yusancky yusancky linked a pull request Jan 25, 2024 that will close this issue
@jcbhmr
Copy link
Member

jcbhmr commented Jan 26, 2024

actually it wouldnt solve the flaky network issues; its still have to download the cached files from actions/cache servers (which are was s3 buckets iirc).

so the question becomes: which is faster? downloading from s3 with all the overhead of "what run/job is this?" plus auth and such via https://npm.im/@actions/cache OR is it faster to just let typst handle things on its own?

oven-sh/setup-bun#14 (comment)

just wanted to point this out before we go all in on caching when it might be faster/better to just chill and let typst handle the caching lol

the reason nodejs needs a cache is that node_modules is HUGE and involves computationally intensive resolving and tar unzipping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants