This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Two bugs related to Issue 8 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and always apply specific values
steveorourke
approved these changes
Feb 6, 2022
There was a problem hiding this comment.
Hey @sgerber-prospection. PR looks good. However, I need you to sign the Tyro CLA before I can merge. See instructions in CONTRIBUTING.md
Hey Steve! Been a while! But I guess PR comments aren't the best place to catch up ;) I sent CLA to opensource@tyro.com over the weekend, but let me know there is an alternative email or it can't be located. |
awrighttyro
approved these changes
Feb 6, 2022
|
Merged. Thanks @sgerber-prospection! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
First issue from @nikimicallef was because of
return thisinsidewithValue(). It mutated the class in place, andspecificValuesmap was lost if further config calls were made. I guess either approach would work but can't mix and match, so fixed by makingwithValue()also return a copy.Second issue - specific values are lost of they are defaulted and
useDefaultsValuesis true was a logic bug, resolved by checking to see if the constructor param is defined and not throwing it away if so.I guess it should be noted these fixes between them change behaviour that some unfortunate tests may have been accidentally relying on? When released probably worth noting...