Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support n string or range filters #42

Open
rbavery opened this issue Dec 10, 2019 · 2 comments
Open

support n string or range filters #42

rbavery opened this issue Dec 10, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@rbavery
Copy link
Contributor

rbavery commented Dec 10, 2019

This would be super useful for whittling down planet scenes that are in the "test" category, fall outside of sensor view angle limits, and are not of a particular instrument type (I'm looking to get all of one type, either PS2 or the new PS2). Filtering by these three categories requires 2 string filters and a range filter (plus I'd also like to filter by boolean, the positional_accuracy flag).

If I run porder idlist with two string filters I get more scenes returned than if I used 1 string filter, which makes me think the second string filter is causing the other string filters to not be ran (using two string filters should return less scenes than 1 string filter)

Running search for a maximum of: 1000000 assets
Total number of assets written to /home/rave/temporal_mixing/data/idlist_standard_and_test.csv ===> 2635
Running search for a maximum of: 1000000 assets
Total number of assets written to /home/rave/temporal_mixing/data/idlist_all_filters.csv ===> 2665
@samapriya samapriya added the enhancement New feature or request label Dec 15, 2019
@samapriya
Copy link
Collaborator

Hey @rbavery
For now it only handles one filter of each type , string or range and so on. The issue is with the common keys overwriting values in the overall payload . In any case I welcome help on figuring this out, there might be a simple fix but I welcome PRs to add this capability or maybe just something fun to explore over Christmas :)

@rbavery
Copy link
Contributor Author

rbavery commented Jan 5, 2020

Gotcha, thanks for the explanation @samapriya. For now I'll filter by whatever reduces the order count the most, and I think using the harmonize option means I don't need to filter by instrument type. I might be able to take a crack at figuring this out later this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants