-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow hierarchy to be created under a certain parent #10
Comments
Hi @tyxla do you have updates on this feature? |
Howdy @RubenMartins! I don't have anything right now, unfortunately, because I've been busy with a lot of stuff recently. But this one is one of my immediate TODOs as soon as I get back to working on this project. Of course, any contributions are welcome and I'd love to help with landing this feature. |
I'm creating this feature and once done will create an PR. The key changes will be:
Anything else you might think of edit this list please. |
I'm also facing an "issue" where I have a lot of terms hierarchically and on slow servers this might create a problem generating the list of terms like 2k+. I'm thinking @tyxla on dynamic list by hierarchy and I think on this 2 possible ways:
What's your feedback on this or input from users? |
Thanks for working on this @RubenMartins! I'm happy to provide any help you might need in the process.
You probably mean "Parent Term", here right? Yes, that's how I'd envision it to work. Maybe we could use something from the WP core for generating the field, like
That makes complete sense - we probably wouldn't want to load all terms from all taxonomies on the initial admin page load.
Not sure what you mean here, could you please elaborate?
Agree; using core WP functions is always a good idea, because most of them are optimized and take advantage of the available caching mechanisms.
Not sure what you mean here, too.
Yes, please 😉 This plugin has been lacking tests from the beginning, but we should probably start with adding tests for the current functionality, and then add up tests for every new feature as we build it.
I think you've done a pretty good job with outlining what needs to be done. Maybe you could add "Hiding the Parent Term field when a non-hierarchical taxonomy is selected" to the list. |
Yes, that's always the case unfortunately, and there are many shared hosts that set the allowed memory too low. Or there are websites that have 50+ plugins enabled at the same time - this could also be the reason behind exhausting the available memory. We can do some things to solve that, fortunately.
I don't think I've seen the WP core break with term hierarchy retrieval with thousands of terms. Maybe we could use what core's using for the term selector field?
That could probably be confusing for some users though. I'd probably consider a more user-friendly interface to be the one like the "tags" in a post, where it autocompletes user's input. So we have a search field, and when the user inputs 2 or more characters, it makes a search and displays only the terms that match that search. That solution makes sense to me, because if you want to create a term hierarchy under a certain parent taxonomy term, you'll definitely know that term parent's name, right? Hope that helps, and again, thanks for working on this one 👍 |
Thanks for the feedback, I have updated the list of TODO with your input and will further proceed. |
No description provided.
The text was updated successfully, but these errors were encountered: