Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error memory limit on one child with same name as parent / or child empty with only the char(s) $ and a blank space after #11

Open
RubenMartins opened this issue Jun 22, 2017 · 4 comments
Labels

Comments

@RubenMartins
Copy link

RubenMartins commented Jun 22, 2017

Hi, I'm having a error on importing child's with same name as parent on a custom taxonomy

For example importing as (import char $):

Tax
$ Tax2
$ Tax
Tax3

This breaks as the Tax as a child with the same name.

This bug also occur when one or more childs are empty

@RubenMartins RubenMartins changed the title Error memory limit on one child with same name as parent Error memory limit on one child with same name as parent / or child empty with only the char(s) $ and a blank space after Jun 26, 2017
@tyxla tyxla added the bug label Jun 26, 2017
@tyxla
Copy link
Owner

tyxla commented Jun 26, 2017

@RubenMartins thanks for reporting that one!

This breaks as the Tax as a child with the same name.

I'm unable to reproduce this one. Could you send me step by step instructions on how to repro it? Thanks!

This bug also occur when one or more childs are empty

I'm not sure how that case should work. WordPress core does not allow creating empty terms in the administration as well. Who would want an empty term name anyway?

@RubenMartins
Copy link
Author

RubenMartins commented Jun 26, 2017

Hi @tyxla

This breaks as the Tax as a child with the same name.

This bug occur on big lists like 2k/3k items and if one of them has a child with the same name as the parent then the memory_limit error appears. This is happening with a import of Country > Council > Parish import on a custom taxonomy.
Now its working because I found this by debugging trying only a few step by step until came to this conclusion.

This probably only be noticed on shared servers with some limitations but after I figure this out and fix the lines with bug the importer worked as expected ;)

This bug also occur when one or more child's are empty

This should not be a common error since there is no need for empty custom tax but this was due to bad building of the list os country>council>parish on a few I by mistake left blank like this

Tax
$ Tax_1
$ Tax_2
$ 
Tax1

Where the third line "$ " causes this issue.

@RubenMartins
Copy link
Author

For your information and debugging my environment is:

Info Version
PHP 7.0.20
WordPress 4.8
Plugin Quick Bulk Taxonomy Term Creator 1.0.4

@tyxla
Copy link
Owner

tyxla commented Jun 26, 2017

Thanks for clarifying @RubenMartins! I'm not planning on working on this plugin immediately, but I will make sure to ping you when I have a solution for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants