Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 3.0 #28

Merged
merged 12 commits into from Aug 26, 2013
Merged

Bootstrap 3.0 #28

merged 12 commits into from Aug 26, 2013

Conversation

Nivl
Copy link

@Nivl Nivl commented Jul 28, 2013

Hi,

I changed the code to make it work with bootstrap 3.0.

Due to a time issue, I only tested simple forms with textarea and text input. I didn't tried formsets and single field rendering, neither the radio and checkbox fields. So you definitively need to check if the code is fully ready for merging.

I'l try to make more tests next weekend if I find time for it.

@Nivl
Copy link
Author

Nivl commented Aug 4, 2013

I just realized that .horizontal-form now use the grid system to align the label with the input. The best thing would be to create a bootstrap-horizontal templatetag to properly handle the case.

@Nivl
Copy link
Author

Nivl commented Aug 10, 2013

Some backward incompatibility changes has been made since the release of Bootstrap RC1, so you'll need to use a more recent commit (like da417c3e7) to use this pull request.

Since Bootstrap evolves very quickly I will only completely test this PR when Bootstrap 3 will be release as final. Right now it seems to be working fine, but several things hasn't been tested (formset, single fields). Meanwhile, if someone find a bug, I'll fix it asap.

@Nivl
Copy link
Author

Nivl commented Aug 24, 2013

I think it's ready now :)

@tzangms
Copy link
Owner

tzangms commented Aug 24, 2013

Cool! I will merge this ASAP

@caumons
Copy link
Contributor

caumons commented Aug 26, 2013

Hi @Nivl! I've just moved to Bootstrap 3 and I've seen your pull request! :) @tzangms I'm really interested in getting it merged. I have to do a heavy work with forms, so I could provide feedback if I find any issues.

tzangms added a commit that referenced this pull request Aug 26, 2013
@tzangms tzangms merged commit 8b91540 into tzangms:master Aug 26, 2013
@tzangms
Copy link
Owner

tzangms commented Aug 26, 2013

Hi @Nivl @caumons,

I have been merge and publish new version to pypi. try pip install django-bootstrap-form==3.0.0

I just try bootstrap 3.0 on my new project, looks great :D

@caumons
Copy link
Contributor

caumons commented Sep 12, 2013

@tzangms @Nivl First of all, thanks for this fantastic work! Since you made the merge I started using it and I found some issues and limitations. So, I've just created a pull request that solved the problems I faced while working with forms. Cheers! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants