Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[no_unique_address]] is used unprotected #128

Closed
anarthal opened this issue Feb 28, 2024 · 1 comment
Closed

[[no_unique_address]] is used unprotected #128

anarthal opened this issue Feb 28, 2024 · 1 comment

Comments

@anarthal
Copy link

anarthal commented Feb 28, 2024

[[no_unique_address]] is C++20 but seems to be used unprotected, which triggers warnings by C++17 compilers.

See this build (edited link): https://drone.cpp.al/boostorg/mysql/545/11/3

Compiler details:

  • toolset=clang-7
  • cxxstd=17
  • variant=debug,release
  • warnings=extra
@tzlaine
Copy link
Owner

tzlaine commented Feb 29, 2024

That warning is objectively dumb. The whole point of an attribute's being ignored by the compiler if the compiler doesn't recognize it is that you can put it in your code, and enjoy the benefits when using later C++ standards, without needing macro guards around your code. I'm not going to add such guards here.

@tzlaine tzlaine closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants