cover/cmds/core/cat #2183
Merged
cover/cmds/core/cat #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2183 +/- ##
==========================================
+ Coverage 60.31% 60.34% +0.02%
==========================================
Files 399 399
Lines 40606 40606
==========================================
+ Hits 24490 24502 +12
+ Misses 15152 15142 -10
+ Partials 964 962 -2
Continue to review full report at Codecov.
|
rminnich
reviewed
Nov 23, 2021
rjoleary
reviewed
Nov 23, 2021
ChriMarMe
force-pushed
the
cover/cmds/cat
branch
4 times, most recently
from
a15f900
to
c2bc9e1
Compare
|
Reworked it again. Maybe this is a little better :) |
rjoleary
reviewed
Nov 27, 2021
ChriMarMe
force-pushed
the
cover/cmds/cat
branch
3 times, most recently
from
4c3ccc1
to
f31935a
Compare
Add more tests Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
ChriMarMe
force-pushed
the
cover/cmds/cat
branch
from
f31935a
to
5e818d0
Compare
rjoleary
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure main
Add test for empty arguments
Add test for file not exist
Add test for io copy fail
Signed-off-by: Christopher Meis christopher.meis@9elements.com