-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wget -O needs to be passed as first argument #2669
Comments
I see -O twice, are you sure it did not pull it down to a file name -O? |
it's not that it is positional, it's that the go flag package takes the standard of switches first and then args. wget's rules around args are very non-standard, but we have little choice but to honor them, including the -- I suppose. Quite the mess. |
Bad copy paste |
man wget | grep '^ *--'|wc |
@rminnich yeah... Sometimes less is more. Nothing can be done here? Even if ugly, if wget is dealing only with one argument (-O) it should tolerate having dst passed after source. Then asking on a use case basis for fix where too tight on expression should be possible for all other u-root applets. But serisouly.... Without wget support, its impossible to get anything "in". |
Fixed per 83a242b |
https://github.com/DeterminateSystems/nix-installer/blob/5a58cf20bec1b34f62e11709a60ed60d2d640353/nix-installer.sh#L314 doesn't work.
Only
wget -O /tmp/nix-installer https://install.determinate.systems/nix/tag/v0.8.0/nix-installer-x86_64-linux
works, but most tools pass -O after URL, not before.-O
should not be positional and only working if provided as first argument...When applied on top of #2668 manually packed under u-root cpio:
The text was updated successfully, but these errors were encountered: