Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated event in eventNames.js ? #26

Closed
cjmling opened this issue Jun 11, 2018 · 2 comments
Closed

Outdated event in eventNames.js ? #26

cjmling opened this issue Jun 11, 2018 · 2 comments

Comments

@cjmling
Copy link

cjmling commented Jun 11, 2018 •
edited

Based on this issue #25 , the callback never called. It work only if i changed to this.

onReady: onReady

Seems like this whole file need to be updated.
https://developers.google.com/youtube/iframe_api_reference#Events

react-youtube/src/eventNames.js

Line 2 in 2c357c5

ready: 'onReady',

@cjmling cjmling mentioned this issue Jun 11, 2018
Closed
@cjmling cjmling changed the title Should this be onReady ? Outdated event in eventNames.js ? Jun 11, 2018
@goto-bus-stop
Copy link
Member

dang, you're­ right—i only use the onPlaying/onPause handlers which were implemented differently so this slipped. thanks!

@goto-bus-stop
Copy link
Member

this and the autoplay issue are addressed in 📦 v0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goto-bus-stop @cjmling