Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined Offset 2 in sortEventsWithOrder #179

Closed
dasgarner opened this issue May 24, 2018 · 2 comments
Closed

Undefined Offset 2 in sortEventsWithOrder #179

dasgarner opened this issue May 24, 2018 · 2 comments

Comments

@dasgarner
Copy link

In the below commit $this->cal['VEVENT'] = $events; has been placed inside an IF statement, which means the modified events array isn't stored at the end of process event.

sortEventsWithOrder then uses dtstart_array[2] which isn't set anymore, causing undefined index exception.

This commit introduced the issue:
72d3d0c#diff-50681920b8994c51dcfbb9a44850348f

Putting $this->cal['VEVENT'] = $events; back outside the IF statement fixes it.

@u01jmg3 u01jmg3 self-assigned this May 24, 2018
@u01jmg3 u01jmg3 added this to the v2.x.x milestone May 24, 2018
@u01jmg3 u01jmg3 removed their assignment May 24, 2018
@u01jmg3
Copy link
Owner

u01jmg3 commented May 24, 2018

Thanks for reporting - checkout v2.1.5

@dasgarner
Copy link
Author

No problem - thanks for the fast turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants