Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some EXDATE are not excluded as expected #240

Closed
britweb-tim opened this issue Sep 10, 2019 · 3 comments
Closed

Some EXDATE are not excluded as expected #240

britweb-tim opened this issue Sep 10, 2019 · 3 comments

Comments

@britweb-tim
Copy link

  • PHP Version: 7.3.8
  • PHP date.timezone: UTC
  • ICS Parser Version: 2.1.15 (dev-master)
  • Linux

Description of the Issue:

EXDATES are not excluded correctly from g-suite calendar iCal feed.

Steps to Reproduce:

Using the following initialisation for ICal

$ical = new ICal\ICal('https://calendar.google.com/...../basic.ics', [
        'defaultSpan'                 => 2,     // Default value
        'defaultTimeZone'             => 'UTC',
        'defaultWeekStart'            => 'MO',  // Default value
        'disableCharacterReplacement' => false, // Default value
        'filterDaysAfter'             => null,  // Default value
        'filterDaysBefore'            => null,  // Default value
        'skipRecurrence'              => false, // Default value
        'useTimeZoneWithRRules'       => false, // Default value
    ]);

The EXDATES from the following ICAL segment are not removed as expected.

In particular the final date Europe/London:20190911T095000 is not excluded.

However Europe/London:20190925T095000 does appear to be excluded correctly.

BEGIN:VEVENT
DTSTART;TZID=Europe/London:20190911T095000
DTEND;TZID=Europe/London:20190911T110500
RRULE:FREQ=WEEKLY;WKST=SU;UNTIL=20191027T235959Z;BYDAY=WE
EXDATE;TZID=Europe/London:20191023T095000
EXDATE;TZID=Europe/London:20191009T095000
EXDATE;TZID=Europe/London:20190925T095000
EXDATE;TZID=Europe/London:20190911T095000
DTSTAMP:20190910T100203Z
UID:4ta52ghl3dq6rku8mh4btuicib@google.com
CREATED:20190822T150032Z
DESCRIPTION:
LAST-MODIFIED:20190902T190633Z
LOCATION:
SEQUENCE:2
STATUS:CONFIRMED
SUMMARY:Members Swim
TRANSP:OPAQUE
END:VEVENT
@britweb-tim britweb-tim changed the title EXDATE timestamp is resolved incorrectly Some EXDATE are not excluded as expected Sep 10, 2019
@thisanimus
Copy link

I'm experiencing the same behavior. For me it's removing all but the last exdate. It looks like if DTSTART is the same day as the first EXDATE, it does not remove it.

@u01jmg3
Copy link
Owner

u01jmg3 commented Nov 13, 2019

@s0600204: can you help?

@u01jmg3
Copy link
Owner

u01jmg3 commented Dec 3, 2019

Fixed by #246

@u01jmg3 u01jmg3 closed this as completed Dec 3, 2019
@u01jmg3 u01jmg3 removed their assignment Dec 3, 2019
@u01jmg3 u01jmg3 added this to the v2.x.x milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants