mpv still remains in the kmix(KDE's volume controller) after closing baka-mplayer by closing its window

[amazingfate]

If baka-mplayer is closed by ctrl+q, it doesn't have this problem.

[u8sand]

I'm having a difficult time reproducing this, could you provide some more information:

• how long it stays
• how did you close the window (x, alt-f4, ?)
• does baka-mplayer ever lag for you?
• what sound server? (alsa, pulse oss)? so I can set it up and try to reproduce
• just to make sure.. it doesn't happen with only mpv does it?

Thanks, it looks somewhat concerning like a leak, but I double checked the source--in particular i'm pretty sure mpv is getting cleaned up properly.

[amazingfate]

It seems that I also can't reproduce this,no matter by x,alt-f4,and ctrl+q.But the one I showed in the picture is still there, and there is no mpv running in my system. It will go away after loging out.
Baka-mplayer never lagged for me, it always runs perfect.
Sound server is ALSA.
With only mpv it doesn't happen.

[amazingfate]

Well I relogged in and tested, this problem happened again. It doesn't happen all the time. Sometimes it happens, sometimes it doesn't.

[u8sand]

I'll leave this open for now but because I'm unable to reproduce it...

Let's just try something--it SHOULDN'T work but who knows.. Try this patch (to the latest commit):

diff --git a/src/ui/mainwindow.cpp b/src/ui/mainwindow.cpp
index 47b52f6..f42e94b 100644
--- a/src/ui/mainwindow.cpp
+++ b/src/ui/mainwindow.cpp
@@ -1184,6 +1184,7 @@ MainWindow::~MainWindow()
         delete dimDialog;
     if(moveTimer)
         delete moveTimer;
+    delete mpv;
     delete ui;
 }

qt is supposed to delete mpv, if not for some ridiculous reason this would take care of it.

[amazingfate]

I forgot to say that when I relogged in, baka-mplayer's window appeared. It should be the one that remained in the kmix. Maybe there was something wrong in my system since it is not easy to be reproduced. I'll try this patch someday.

[amazingfate]

I tried this patch and tested it for days, and it seems that it works. I suggest this patch added into the source code.

[u8sand]

Ok thanks for the info, it means I should no longer trust Qt to delete objects for me. I'm glad your problem was fixed.