Skip to content

Commit

Permalink
refactor: formatter, flat is better than nested
Browse files Browse the repository at this point in the history
  • Loading branch information
u8slvn committed Jul 21, 2019
1 parent e6d55a9 commit 651946c
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions rerwatcher/transilien.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,20 @@ def format(self, data: str, limit: int = 2):
response_body = data.encode(self.encoding)
tree = etree.fromstring(response_body)
trains = tree.xpath('/passages/train')
timetables = []

for train in trains[:limit]:
miss = train.find('miss').text
date = train.find('date').text
timetables = [self._format_train(train) for train in trains[:limit]]
return timetables

date = datetime.strptime(date, self.date_format)
time_delta = date - datetime.now()
def _format_train(self, train):
miss = train.find('miss').text
date = train.find('date').text

time = self._format_timedelta(time_delta=time_delta)
timetable = f'{miss}: {time}'
timetables.append(timetable)
date = datetime.strptime(date, self.date_format)
time_delta = date - datetime.now()

return timetables
time = self._format_timedelta(time_delta=time_delta)
timetable = f'{miss}: {time}'
return timetable

@staticmethod
def _format_timedelta(time_delta: timedelta):
Expand Down

0 comments on commit 651946c

Please sign in to comment.