Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Firefox: uBlock popup is blank #1027

Closed
ozar opened this issue Mar 16, 2015 · 19 comments
Closed

Firefox: uBlock popup is blank #1027

ozar opened this issue Mar 16, 2015 · 19 comments

Comments

@ozar
Copy link

ozar commented Mar 16, 2015

Running Firefox 36.0.1 on Linux

The current data/stats areas and version indicator of the ublock popup are blank after upgrading from 0.9.1.1 to version 0.9.1.2-dev.1

I've tried simply upgrading, and I've tried removing uBlock, then fresh installing the dev version, but still no stats or version indicator on the popup.

Dropping back to 0.9.1.1 gets things working properly again.

@gorhill
Copy link
Contributor

gorhill commented Mar 16, 2015

I've had the same symptom. Quitting and restarting Firefox solved the issue.

@ozar
Copy link
Author

ozar commented Mar 16, 2015

That's one thing I didn't try, so I'll give it another go and see what happens. Thanks!

@ozar
Copy link
Author

ozar commented Mar 16, 2015

No luck here with a Firefox restart. I noticed also that the dev version is leaving all filters off of the the 3rd-party filters tab. Only the lines regarding auto-updates and parsing cosmetic filters is showing up, along with the custom filter examples.

@gorhill
Copy link
Contributor

gorhill commented Mar 16, 2015

Can you look in the browser console[1] if there are error messages?

[1] Ctrl-Shift-J

@gorhill
Copy link
Contributor

gorhill commented Mar 16, 2015

What a strange coincidence... I just reproduced, my +"3rd-party filters" pane is also empty.

Investigating.

@ozar
Copy link
Author

ozar commented Mar 16, 2015

With a fresh start in Firefox, opening the uBlock popup and checking the browser console is giving a security error:

SecurityError: The operation is insecure. popup.js:36:0

@gorhill
Copy link
Contributor

gorhill commented Mar 16, 2015

@Deathamns, @AlexVallat I am confused. The browser complains that vAPI.lastError is not a function, while it is clearly defined in vapi-background.js. I tried to launch the browser to break on vAPI.lastError() in assets.js, but the breakpoint was never triggered:

d

@gorhill
Copy link
Contributor

gorhill commented Mar 16, 2015

@ozar I don't get this one. What operation, are there details about it?

@ozar
Copy link
Author

ozar commented Mar 16, 2015

No details really. The console had many lines, I cleared it, then opened the uBlock popup, and that one line regarding security is all that comes up unless I do other things in Firefox. Of course, the data is still missing from the popup window.

@gorhill
Copy link
Contributor

gorhill commented Mar 16, 2015

My popup works, it's my 3rd-party filters pane which is broken.

There seems to be something going on, I can't tell what. I get these "security error" warnings too:

Security Error: Content at moz-nullprincipal:{41ee2473-2e49-46e9-b9f2-dcd73dcdc6d9} may not load or link to chrome://ublock/content/settings.html.
Security Error: Content at moz-nullprincipal:{41ee2473-2e49-46e9-b9f2-dcd73dcdc6d9} may not load or link to chrome://ublock/content/3p-filters.html.

I can't tell what is {41ee2473-2e49-46e9-b9f2-dcd73dcdc6d9}. This remiinds me of this other report earlier today: gorhill/uBlock#1020 (comment). However as opposed to that case, I have no other add-on enabled.

@gorhill
Copy link
Contributor

gorhill commented Mar 16, 2015

Quitting and restarting Firefox fixed the issue on my side, but there is definitely a problem to fix somewhere.

@ozar
Copy link
Author

ozar commented Mar 16, 2015

I generally only use static filtering, but just noticed that even when I try to use dynamic filtering, the popup won't open up fully giving me access to the advanced information. It remains in static mode, with no stats. Restarting Firefox doesn't help in my case.

@my-password-is-password

@gorhill is {41ee2473-2e49-46e9-b9f2-dcd73dcdc6d9} some generated id for ublock? Because that id I had in my error from that screenshot is now another id :

Security Error: Content at moz-nullprincipal:{2dce829b-50fb-4042-b19d-3197ea600260} may not load or link to chrome://ublock/content/3p-filters.html.

@gorhill
Copy link
Contributor

gorhill commented Mar 16, 2015

I have a feeling this might be related to that change, because the first thing executed when opening the popup is accessing that local storage. That storage is also used in the 3rd-party filters pane.

Anyways, I will remove the use from the popup, as in the end it did not solve the issue I was trying to solve( #996).

@gorhill
Copy link
Contributor

gorhill commented Mar 16, 2015

@my-password-is-password Yes, after restarting Firefox I get similar errors but with a new id.

@ozar
Copy link
Author

ozar commented Mar 16, 2015

Note that all the issues I've described above, including the security issue in console, go away when I drop back to version 0.9.1.1

@gorhill
Copy link
Contributor

gorhill commented Mar 16, 2015

Yes, 0.9.1.1 is almost same as 0.9.1.0, it was mostly an emergency fix for Chromium. 0.9.1.1 does not contains that local storage code.

@Deathamns
Copy link
Contributor

I changed vAPI.localStorage to Firefox config (which shouldn't be used for large data), test with that...

By the way, about these Security Error: Content at moz-nullprincipal... errors, just ignore them.

@ozar
Copy link
Author

ozar commented Mar 16, 2015

Just a quick note to say that version 0.9.1.2-dev.2 has fixed all the issues I've described above.

Thanks for the fixes. :)

EDIT: sorry for the double post but for some reason, the GigHub software was not allowing me to edit the other post like this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants