You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
I don't believe this happens all the time but found a good page that provides an example. At the following page, as you click through the pictures, you'll see a blocked ad appear at the top of the page and everything shift down for a fraction of a second, then shift back up. This is with only the easylist filter and nothing else.
Adblock Plus also has the same problem, but Adblock (getadblock.com) does not. With Adblock, as you click through the slideshow of pictures, the page remains static, with no shifting around.
Title is misleading: The ad is blocked. The placeholder however is collapsed later.
I don't know anything about AdBlock's code, aside that it's the most CPU intensive blocker out there. I see there is also a re-layout occurring with AdBlock, the whole page shift upward, though I didn't see the ugly placeholder.
That said, given how trivial the issue, the simplest fix is to just create the appropriate cosmetic filter:
www.dpreview.com##.ad.top
Result is even better than with AdBlock, there is no page shift upward. Even better, submit the filter to EasyList crowd so everybody benefit from it regardless of the blocker used.
By the way, I see AdBlock redirect the iframe to about:blank, which may explain why you do not see Chromium's default placeholder (the gray ascii face). Very early in the project I had to stop using redirection for blocked contents, for good reasons.
I don't believe this happens all the time but found a good page that provides an example. At the following page, as you click through the pictures, you'll see a blocked ad appear at the top of the page and everything shift down for a fraction of a second, then shift back up. This is with only the easylist filter and nothing else.
Adblock Plus also has the same problem, but Adblock (getadblock.com) does not. With Adblock, as you click through the slideshow of pictures, the page remains static, with no shifting around.
http://www.dpreview.com/articles/8635354300/beautiful-dreamer-garret-suhrie-landscapes
The text was updated successfully, but these errors were encountered: