Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Ads don't get blocked before page loads #460

Closed
sstouffer opened this issue Jan 4, 2015 · 3 comments
Closed

Ads don't get blocked before page loads #460

sstouffer opened this issue Jan 4, 2015 · 3 comments

Comments

@sstouffer
Copy link

I don't believe this happens all the time but found a good page that provides an example. At the following page, as you click through the pictures, you'll see a blocked ad appear at the top of the page and everything shift down for a fraction of a second, then shift back up. This is with only the easylist filter and nothing else.

Adblock Plus also has the same problem, but Adblock (getadblock.com) does not. With Adblock, as you click through the slideshow of pictures, the page remains static, with no shifting around.

http://www.dpreview.com/articles/8635354300/beautiful-dreamer-garret-suhrie-landscapes

@gorhill
Copy link
Contributor

gorhill commented Jan 4, 2015

Title is misleading: The ad is blocked. The placeholder however is collapsed later.

I don't know anything about AdBlock's code, aside that it's the most CPU intensive blocker out there. I see there is also a re-layout occurring with AdBlock, the whole page shift upward, though I didn't see the ugly placeholder.

That said, given how trivial the issue, the simplest fix is to just create the appropriate cosmetic filter:

www.dpreview.com##.ad.top

Result is even better than with AdBlock, there is no page shift upward. Even better, submit the filter to EasyList crowd so everybody benefit from it regardless of the blocker used.

@gorhill gorhill closed this as completed Jan 4, 2015
@gorhill
Copy link
Contributor

gorhill commented Jan 4, 2015

By the way, I see AdBlock redirect the iframe to about:blank, which may explain why you do not see Chromium's default placeholder (the gray ascii face). Very early in the project I had to stop using redirection for blocked contents, for good reasons.

@sstouffer
Copy link
Author

Thank you for the detailed response! I have since submitted a report to easylist. Keep up the great work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants