Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Can't open datacenter.biathlonresults.com, jQuery was not found. #665

Closed
andrey-budko opened this issue Feb 2, 2015 · 10 comments
Closed

Comments

@andrey-budko
Copy link

Can't open http://datacenter.biathlonresults.com/ if uBlock is enabled.

JavaScript console:
Error: jQuery was not found. Please ensure jQuery is referenced before the SignalR client JavaScript file.
ReferenceError: $ is not defined.

Works fine with AdBlock Plus

uBlock 0.8.6, Firefox 35

@Mikey1993
Copy link
Contributor

Add this exception filter to your "My filters" list:
@@||info$script,domain=biathlonresults.com

@gorhill
Copy link
Contributor

gorhill commented Feb 2, 2015

It opens fine with default filter lists. What are your filter lists? Custom filters? Etc. Details please, saves time to all.

@andrey-budko
Copy link
Author

It breaks after enabling
RUS: RU AdList (Дополнительная региональная подписка)‎

Full list of subscriptions I used:

My filters‎: 0 used out of 0
µBlock filters‎: 119 used out of 119
µBlock filters – Privacy‎: 2 used out of 2

EasyList‎ (adblockplus.org): 52 557 used out of 52 593
Peter Lowe’s Ad server list‎ (yoyo.org): 2 402 used out of 2 452

EasyPrivacy‎ (adblockplus.org): 9 739 used out of 9 745

Malware Domain List‎ (malwaredomainlist.com): 1 511 used out of 1 525
Malware domains‎: 17 244 used out of 20 125
Malware domains (long-lived)‎: 2 737 used out of 2 737

Fanboy’s Social Blocking List‎ (adblockplus.org): 11 487 used out of 11 490

RUS: RU AdList (Дополнительная региональная подписка)‎ (adblockplus.org): 6 860 used out of 6 860

@Mikey1993
Copy link
Contributor

Right, this is why I was able to reproduce this.
RUS: RU AdList (Дополнительная региональная подписка)‎ is not a list which is enabled by default.

@gorhill
Copy link
Contributor

gorhill commented Feb 2, 2015

@andrey-budko So you are telling me that ABP with RU Adlist does not have the problem? (I can't try right now as https://easylist-downloads.adblockplus.org/ is down.)

@gorhill
Copy link
Contributor

gorhill commented Feb 2, 2015

Ok, I could finally try it with ABP and it does not have the problem. This filter is the cause:

||info^$third-party,script

Investigating.

@andrey-budko
Copy link
Author

With ABP I use «RuAdList+EasyList» preset. It refers to:
https://easylist-downloads.adblockplus.org/ruadlist+easylist.txt

@gorhill
Copy link
Contributor

gorhill commented Feb 2, 2015

Problem is here: https://github.com/gorhill/uBlock/blob/master/src/js/static-net-filtering.js#L1321

TODO: transforming ^ into * is not a strict interpretation of ABP syntax.

@gorhill
Copy link
Contributor

gorhill commented Feb 2, 2015

Investigating for best fix. I will experiment with one that I figure could actually increase uBlock's efficiency of the network requests handler -- will benchmark to validate. I will take my time, I don't want to rush things.

Meanwhile, workaround above by @Mikey1993 works.

@gorhill
Copy link
Contributor

gorhill commented Feb 3, 2015

After changes to fix the bug:

µBlock> onBeforeRequest: 0.131 ms (8664 samples)
µBlock> onBeforeRequest: 0.131 ms (8763 samples)
µBlock> onBeforeRequest: 0.131 ms (8839 samples)
µBlock> onBeforeRequest: 0.130 ms (8914 samples)
µBlock> onBeforeRequest: 0.131 ms (8988 samples)
µBlock> onBeforeRequest: 0.131 ms (9033 samples)
µBlock> onBeforeRequest: 0.130 ms (9192 samples)
µBlock> onBeforeRequest: 0.130 ms (9206 samples)
µBlock> onBeforeRequest: 0.129 ms (9324 samples)
µBlock> onBeforeRequest: 0.129 ms (9329 samples)

Also, this was after I moved the start of profiling to the platform-specific code (the earliest entry point into uBlock's code), something I forgot to do with the last results (I will revise the last results to use the results here).

@gorhill gorhill closed this as completed in 7a5d09b Feb 4, 2015
@gorhill gorhill removed the Fixing label Feb 4, 2015
@gorhill gorhill changed the title [Firefox] Can't open datacenter.biathlonresults.com, jQuery was not found. Can't open datacenter.biathlonresults.com, jQuery was not found. Feb 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants