Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

contentscript-end.js: remove overhead of short-lived function expression #683

Closed
gorhill opened this issue Feb 4, 2015 · 4 comments
Closed

contentscript-end.js: remove overhead of short-lived function expression #683

gorhill opened this issue Feb 4, 2015 · 4 comments

Comments

@gorhill
Copy link
Contributor

gorhill commented Feb 4, 2015

We can get rid of the closure, hence the overhead of the function expression created for each image/iframe/object's load/error event.
@chrisaljoudi
Copy link
Contributor

@gorhill line no.?

@gorhill
Copy link
Contributor Author

gorhill commented Feb 4, 2015

Core code.

@gorhill gorhill closed this as completed in c7edec0 Feb 4, 2015
@chrisaljoudi
Copy link
Contributor

@gorhill sure, was just curious — sorry. :)

@gorhill
Copy link
Contributor Author

gorhill commented Feb 4, 2015

The onAnswerReceived function was created for each load or error event.

I was laconic because I was about to commit the changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gorhill @chrisaljoudi